You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ratis.apache.org by GitBox <gi...@apache.org> on 2020/05/19 09:37:58 UTC
[GitHub] [incubator-ratis] runzhiwang opened a new pull request #106: RATIS-942. Fix can not create raftLogMetrics when one RaftServerProxy.id belongs to different group
runzhiwang opened a new pull request #106:
URL: https://github.com/apache/incubator-ratis/pull/106
What's the problem ?
when create `RaftLogMetrics`, it use `memberId.getPeerId()` to identify, the `peerId` comes from `RaftServerProxy::getId`. So if one Ratis node belongs to different group, the `peerId` is same for different `RaftLogMetrics`. When create the second `RaftLogMetrics` for the second group, it will not create, because it's been created by the first group.
How to fix ?
`memberId.toString()` will return `peerId + "@" + groupId`.
@bshashikant @lokeshj1703 Could you help review it ? Thank you very much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang commented on pull request #106: RATIS-942. Fix can not create raftLogMetrics in multi-raft
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #106:
URL: https://github.com/apache/incubator-ratis/pull/106#issuecomment-633445644
@dineshchitlangia Thanks for you review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang commented on pull request #106: RATIS-942. Fix can not create raftLogMetrics in multi-raft
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #106:
URL: https://github.com/apache/incubator-ratis/pull/106#issuecomment-630853477
@bshashikant @lokeshj1703 Could you help review it ? Thank you very much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org