You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2022/10/21 12:36:34 UTC

[GitHub] [skywalking-java] pg-yang commented on pull request #362: Polish up rabbitmq-5.x plugin to fix missing broker tag on consumer side

pg-yang commented on PR #362:
URL: https://github.com/apache/skywalking-java/pull/362#issuecomment-1286904932

   @wu-sheng  Did you look the above comment ?  
   In a word  ,  `NotNullAssertor `  maybe not accurate  with tag which value is null .
   We  could  provide  `NotBlankAssertor` in  test  tool project  , or  set the value to  keyValueBuilder even if it's null 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org