You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Darryl L. Miles (JIRA)" <ji...@apache.org> on 2012/06/22 21:06:42 UTC
[jira] [Updated] (WICKET-4625)
ServletWebRequest#getContextRelativeUrl() sometimes chops off leading
characters
[ https://issues.apache.org/jira/browse/WICKET-4625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Darryl L. Miles updated WICKET-4625:
------------------------------------
Attachment: 0001-WICKET-4625-ServletWebRequest-getContextRelativeUrl-.patch
This is for 1.5.x and 1.6.x (tested on 6.0-SNAPSHOT)
See comment above and inside git patch file.
> ServletWebRequest#getContextRelativeUrl() sometimes chops off leading characters
> --------------------------------------------------------------------------------
>
> Key: WICKET-4625
> URL: https://issues.apache.org/jira/browse/WICKET-4625
> Project: Wicket
> Issue Type: Bug
> Reporter: Darryl L. Miles
> Attachments: 0001-WICKET-4625-ServletWebRequest-getContextRelativeUrl-.patch
>
>
> This patch reduces the number of nonsense return value this method might produce. I have clarified the in JavaDoc the expected inputs to the method. It is still possible to still get a nonsense return values in some use cases, all scenarios are documented and tested in a new test case.
> This method presumes that the input "uri" on the 1st argument always has the ContextPath and then the FilterPrefix on the front of the URL.
> Some unit tests were actually checking the nonsense return values were being returned these have been updated.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira