[jira] [Commented] (LUCENE-5889) AnalyzingInfixSuggester should expose commit()

["Michael McCandless (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-5889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14104098#comment-14104098 ] 

Michael McCandless commented on LUCENE-5889:
--------------------------------------------

Thanks Varun!

I think we shouldn't add another ctor?  (The API is experimental.).
Just add the new commitOnBuild param ...

I think it's fine to init the writer in add/update, but can you pull
that out to its own method, e.g. getWriter?  And I guess it should be
sync'd, in case multiple threads try to add/update at once?

And maybe add some tests showing that you can just use .add and then
refresh and see the suggestions?


> AnalyzingInfixSuggester should expose commit()
> ----------------------------------------------
>
>                 Key: LUCENE-5889
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5889
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/spellchecker
>            Reporter: Mike Sokolov
>         Attachments: LUCENE-5889.patch
>
>
> There is no way short of close() for a user of AnalyzingInfixSuggester to cause it to commit() its underlying index: only refresh() is provided.  But callers might want to ensure the index is flushed to disk without closing.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org