You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jason Zhou <ja...@gmail.com> on 2024/07/24 18:26:49 UTC
Re: Review Request 75106: [devices] Add Selector::encompasses
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75106/
-----------------------------------------------------------
(Updated July 24, 2024, 6:26 p.m.)
Review request for mesos and Benjamin Mahler.
Summary (updated)
-----------------
[devices] Add Selector::encompasses
Repository: mesos
Description
-------
Currently, we have to check via Selector's membervariables if the
devices represented by one Selector encompasses those represented by
another.
We add a helper function to simplify the logic which differ depending on
whether one Selector encompasses the other.
Diffs
-----
src/linux/cgroups.hpp 4fefb5c3b34c539197967afff0b0b533f47852c8
src/linux/cgroups.cpp 3dae320bd54e81175ff5acaa007f4c6805d6cb4c
src/tests/containerizer/cgroups_tests.cpp e4ca7933ba692aacf3cdba0c4a6c1411c1a47604
Diff: https://reviews.apache.org/r/75106/diff/1/
Testing
-------
Unit tests added, tests pass
Thanks,
Jason Zhou
Re: Review Request 75106: [devices] Add Selector::encompasses
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/75106/#review226715
-----------------------------------------------------------
Ship it!
src/linux/cgroups.hpp
Lines 959-960 (patched)
<https://reviews.apache.org/r/75106/#comment314994>
we can use this in Entry::encompasses?
- Benjamin Mahler
On July 24, 2024, 6:26 p.m., Jason Zhou wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/75106/
> -----------------------------------------------------------
>
> (Updated July 24, 2024, 6:26 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Currently, we have to check via Selector's membervariables if the
> devices represented by one Selector encompasses those represented by
> another.
>
> We add a helper function to simplify the logic which differ depending on
> whether one Selector encompasses the other.
>
>
> Diffs
> -----
>
> src/linux/cgroups.hpp 4fefb5c3b34c539197967afff0b0b533f47852c8
> src/linux/cgroups.cpp 3dae320bd54e81175ff5acaa007f4c6805d6cb4c
> src/tests/containerizer/cgroups_tests.cpp e4ca7933ba692aacf3cdba0c4a6c1411c1a47604
>
>
> Diff: https://reviews.apache.org/r/75106/diff/1/
>
>
> Testing
> -------
>
> Unit tests added, tests pass
>
>
> Thanks,
>
> Jason Zhou
>
>