You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Sebb (JIRA)" <ji...@apache.org> on 2015/08/12 17:31:45 UTC

[jira] [Resolved] (BCEL-239) Interfaces should not be used to define constants

     [ https://issues.apache.org/jira/browse/BCEL-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb resolved BCEL-239.
-----------------------
    Resolution: Fixed

URL: http://svn.apache.org/r1695556
Log:
BCEL-239 Interfaces should not be used to define constants

Modified:
    commons/proper/bcel/trunk/src/changes/changes.xml
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/Constants.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/AnnotationEntry.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/CodeException.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/LocalVariable.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/classfile/ParameterAnnotationEntry.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/util/AttributeHTML.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/util/Class2HTML.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/util/CodeHTML.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/util/ConstantHTML.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/util/MethodHTML.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier/statics/Pass2Verifier.java
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/verifier/structurals/UninitializedObjectType.java
    commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestArrayAccess02Creator.java
    commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestArrayAccess03Creator.java
    commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestArrayAccess04Creator.java
    commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestReturn01Creator.java
    commons/proper/bcel/trunk/src/test/java/org/apache/commons/bcel6/verifier/tests/TestReturn03Creator.java



> Interfaces should not be used to define constants
> -------------------------------------------------
>
>                 Key: BCEL-239
>                 URL: https://issues.apache.org/jira/browse/BCEL-239
>             Project: Commons BCEL
>          Issue Type: Bug
>            Reporter: Sebb
>            Assignee: Charles Honton
>             Fix For: 6.0
>
>
> Interfaces should not be used to define constants.
> This is often done as a way to save typing the name of a class that defines the constants. However using an interface pollutes any implementing classes with all the constant names, even if they are not used.
> This issue applies to
> Constants
> ExceptionConstants
> InstructionConstants



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)