You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/05/22 17:33:35 UTC

[GitHub] [incubator-hudi] garyli1019 commented on a change in pull request #1652: [HUDI-918] Fix kafkaOffsetGen can not read kafka data bug

garyli1019 commented on a change in pull request #1652:
URL: https://github.com/apache/incubator-hudi/pull/1652#discussion_r429371998



##########
File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/sources/helpers/KafkaOffsetGen.java
##########
@@ -207,6 +208,11 @@ public KafkaOffsetGen(TypedProperties props) {
     maxEventsToReadFromKafka = (maxEventsToReadFromKafka == Long.MAX_VALUE || maxEventsToReadFromKafka == Integer.MAX_VALUE)
         ? Config.maxEventsFromKafkaSource : maxEventsToReadFromKafka;
     long numEvents = sourceLimit == Long.MAX_VALUE ? maxEventsToReadFromKafka : sourceLimit;
+
+    if (numEvents < toOffsets.size()) {

Review comment:
       Do you mean something like setting sourceLimit to 5 but you have 10 kafka partitions? Why setting sourceLimit to this small?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org