[jira] [Updated] (SLING-7074) RRD4J NPE on removing all "Data sources" from config

["Alex Deparvu (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SLING-7074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alex Deparvu updated SLING-7074:
--------------------------------
    Attachment: SLING-7074.patch

attaching proposed patch.
tried to fallback to defaults whenever possible. could not find a way to expose the archives, so this specific info is borderline useless (at least it shows the count). did not cover the path param at all in tests, but I'm willing to update the patch if this is needed.

Bonus, I added a debug log for value updates. This was there for a single value type but went away, I found it useful so I added it for all cases. If it's not interesting, I can remove it and update a new version of the patch.

[~mreutegg] how does this look to you?

> RRD4J NPE on removing all "Data sources" from config
> ----------------------------------------------------
>
>                 Key: SLING-7074
>                 URL: https://issues.apache.org/jira/browse/SLING-7074
>             Project: Sling
>          Issue Type: Bug
>          Components: Commons
>            Reporter: Alex Deparvu
>            Priority: Minor
>             Fix For: Commons Metrics RRD4J 1.0.0
>
>         Attachments: SLING-7074.patch
>
>
> Opened the config manager and deleted all entries
> {noformat}
>   *ERROR* [CM Event Dispatcher (Fire ConfigurationEvent: pid=org.apache.sling.commons.metrics.rrd4j.impl.CodahaleMetricsReporter)] org.apache.sling.commons.metrics-rrd4j [org.apache.sling.commons.metrics.rrd4j.impl.CodahaleMetricsReporter(3134)] The activate method has thrown an exception (java.lang.NullPointerException)
> java.lang.NullPointerException: null
>     at org.apache.sling.commons.metrics.rrd4j.impl.RRD4JReporter$Builder.withDatasources(RRD4JReporter.java:91)
>     at org.apache.sling.commons.metrics.rrd4j.impl.CodahaleMetricsReporter.activate(CodahaleMetricsReporter.java:143)
>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke(Method.java:498)
> {noformat}
> fyi [~mreutegg]



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)