You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org> on 2018/01/02 22:35:47 UTC
[kudu-CR] KUDU-1704: add java client support for READ OWN WRITES mode
David Ribeiro Alves has posted comments on this change. ( http://gerrit.cloudera.org:8080/8847 )
Change subject: KUDU-1704: add java client support for READ_OWN_WRITES mode
......................................................................
Patch Set 1:
(3 comments)
I know you're rewording some of this but had these unposted comments. might as well post them
http://gerrit.cloudera.org:8080/#/c/8847/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java
File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java:
http://gerrit.cloudera.org:8080/#/c/8847/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@132
PS1, Line 132: * Reads in this mode are not repeatable: two stale reads, even if they
: * provide the same propagated timestamp bound, can execute at different
: * timestamps and thus return inconsistent results. However, it allows
: * read-your-writes for each client, as the picked timestamp must be higher
: * than the one of the last write or read, known from the propagated timestamp.
let's reword this according to what we discussed in the other patch
http://gerrit.cloudera.org:8080/#/c/8847/1/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@138
PS1, Line 138: * In ACID terms this corresponds to Isolation mode: "Read Committed"
This isn't true, is it?
http://gerrit.cloudera.org:8080/#/c/8847/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java:
http://gerrit.cloudera.org:8080/#/c/8847/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@986
PS1, Line 986: testScanOwnSyncWrites
nit: testReadOwnWritesSync?
same below
--
To view, visit http://gerrit.cloudera.org:8080/8847
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6239521c022147257859e399f55c6f3f945af465
Gerrit-Change-Number: 8847
Gerrit-PatchSet: 1
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 02 Jan 2018 22:35:47 +0000
Gerrit-HasComments: Yes