You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2019/03/02 00:58:14 UTC
Review Request 70085: Fixed a link error on Windows caused by volume
gid manager.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70085/
-----------------------------------------------------------
Review request for mesos and Gilbert Song.
Bugs: MESOS-9621
https://issues.apache.org/jira/browse/MESOS-9621
Repository: mesos
Description
-------
Fixed a link error on Windows caused by volume gid manager.
Diffs
-----
src/slave/main.cpp 344aa66b0f49d53cabb2f0d8f0e61c39d32f18a3
Diff: https://reviews.apache.org/r/70085/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 70085: Fixed a link error on Windows caused by
volume gid manager.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70085/#review213357
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On March 1, 2019, 4:58 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70085/
> -----------------------------------------------------------
>
> (Updated March 1, 2019, 4:58 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-9621
> https://issues.apache.org/jira/browse/MESOS-9621
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a link error on Windows caused by volume gid manager.
>
>
> Diffs
> -----
>
> src/slave/main.cpp 344aa66b0f49d53cabb2f0d8f0e61c39d32f18a3
>
>
> Diff: https://reviews.apache.org/r/70085/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 70085: Fixed a link error on Windows caused by
volume gid manager.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70085/#review213355
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70085]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 1, 2019, 4:58 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70085/
> -----------------------------------------------------------
>
> (Updated March 1, 2019, 4:58 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Bugs: MESOS-9621
> https://issues.apache.org/jira/browse/MESOS-9621
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a link error on Windows caused by volume gid manager.
>
>
> Diffs
> -----
>
> src/slave/main.cpp 344aa66b0f49d53cabb2f0d8f0e61c39d32f18a3
>
>
> Diff: https://reviews.apache.org/r/70085/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>