[GitHub] nwangtw closed pull request #3147: [UI] Move reset view button to left and change plan graph listener fr…

[GitBox <gi...@apache.org>]

nwangtw closed pull request #3147: [UI] Move reset view button to left and change plan graph listener fr…
URL: https://github.com/apache/incubator-heron/pull/3147
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/heron/tools/ui/resources/static/css/visstyle.css b/heron/tools/ui/resources/static/css/visstyle.css
index 910993573d..6ad85adadc 100644
--- a/heron/tools/ui/resources/static/css/visstyle.css
+++ b/heron/tools/ui/resources/static/css/visstyle.css
@@ -29,7 +29,7 @@
 .reset {
   position: absolute;
   top: 1em;
-  right: 1em;
+  left: 1em;
   z-index: 100;
 }
 
diff --git a/heron/tools/ui/resources/static/js/logical-plan.js b/heron/tools/ui/resources/static/js/logical-plan.js
index 99b680dad8..e5cb53134a 100644
--- a/heron/tools/ui/resources/static/js/logical-plan.js
+++ b/heron/tools/ui/resources/static/js/logical-plan.js
@@ -393,6 +393,7 @@
           return d.color;
         })
         .on("click", planController.logicalComponentClicked)
+        .on("dblclick", planController.logicalComponentClicked)
         .on("mouseover", planController.logicalComponentHoverOver)
         .on("mouseout", planController.logicalComponentHoverOut);
 
@@ -402,6 +403,7 @@
         .attr("y", function (d) { return d.cy - d.r - 10; })
         .attr("class", "fade")
         .style("text-anchor", "middle")
+        .style("user-select", "all")
         .text(function (d) {
           if (d.isReal) {
             return d.name;
diff --git a/heron/tools/ui/resources/static/js/plan-controller.js b/heron/tools/ui/resources/static/js/plan-controller.js
index 0567a2f244..5482e430aa 100644
--- a/heron/tools/ui/resources/static/js/plan-controller.js
+++ b/heron/tools/ui/resources/static/js/plan-controller.js
@@ -184,8 +184,8 @@ function PlanController(baseUrl, cluster, environ, toponame, physicalPlan, logic
     highlightFocusedElements();
   };
 
-  // treat any click that bubbles up unhandled as intent to clear the focus
-  $(document).on('click', ".plans .graphics", function () {
+  // treat double click as intent to clear the focus
+  $(document).on('dblclick', ".plans .graphics", function () {
     window.location.hash = "/";
   });
   $(document).on('click', ".reset", function () {


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services