You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/08/09 10:21:38 UTC

[GitHub] [incubator-seatunnel] chocolateBlack opened a new pull request, #2389: Self-Achieved Redis Proxy which is not support redis function of "info replication"

chocolateBlack opened a new pull request, #2389:
URL: https://github.com/apache/incubator-seatunnel/pull/2389

   https://github.com/apache/incubator-seatunnel/issues/2150
   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   ## Check list
   
   * [x] Code changed are covered with tests, or it does not need tests for reason:
   * [x] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [x] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #2389: Self-Achieved Redis Proxy which is not support redis function of "info replication"

Posted by GitBox <gi...@apache.org>.
CalvinKirs merged PR #2389:
URL: https://github.com/apache/incubator-seatunnel/pull/2389


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] chocolateBlack commented on pull request #2389: Self-Achieved Redis Proxy which is not support redis function of "info replication"

Posted by GitBox <gi...@apache.org>.
chocolateBlack commented on PR #2389:
URL: https://github.com/apache/incubator-seatunnel/pull/2389#issuecomment-1210388662

   > @chocolateBlack Please add license header, thx.
   @wuchunfu  licence header is added , is that ok?  please do me a favor to check it 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] wuchunfu commented on pull request #2389: Self-Achieved Redis Proxy which is not support redis function of "info replication"

Posted by GitBox <gi...@apache.org>.
wuchunfu commented on PR #2389:
URL: https://github.com/apache/incubator-seatunnel/pull/2389#issuecomment-1212677002

   @chocolateBlack Please update the relevant documentation, thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] CalvinKirs commented on pull request #2389: Self-Achieved Redis Proxy which is not support redis function of "info replication"

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on PR #2389:
URL: https://github.com/apache/incubator-seatunnel/pull/2389#issuecomment-1216063427

   Could you check connector-v2? does it have this feature?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] chocolateBlack commented on pull request #2389: Self-Achieved Redis Proxy which is not support redis function of "info replication"

Posted by GitBox <gi...@apache.org>.
chocolateBlack commented on PR #2389:
URL: https://github.com/apache/incubator-seatunnel/pull/2389#issuecomment-1216239734

   > Could you check connector-v2? does it have this feature?
   
   @CalvinKirs There is no Redis Sink in connector-v2. 
   what's the different between v1 and v2. Is there any docs for us to learn the purpose and details of v2. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org