You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Hugo Trippaers <ht...@schubergphilis.com> on 2012/07/09 14:45:05 UTC

Review Request: fix for broken attachVolume command

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5834/
-----------------------------------------------------------

Review request for cloudstack.


Description
-------

attachVolume is broken as a call to this command will result in a NPE. The cause appears to be that _hostVolumeDao is null during execution. The root cause is that the HostVolumeDao is missing the @Inject annotation.


Diffs
-----

  server/src/com/cloud/vm/UserVmManagerImpl.java 87d88a4 

Diff: https://reviews.apache.org/r/5834/diff/


Testing
-------

clean-all build-all deploy-server

create volume and attach to existing host.. success


Thanks,

Hugo Trippaers

Re: Review Request: fix for broken attachVolume command

Posted by David Nalley <da...@gnsa.us>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5834/#review9157
-----------------------------------------------------------


Hugo, would you mind filing a bug for this along with the output from the NPE

- David Nalley


On July 9, 2012, 12:45 p.m., Hugo Trippaers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/5834/
> -----------------------------------------------------------
> 
> (Updated July 9, 2012, 12:45 p.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> attachVolume is broken as a call to this command will result in a NPE. The cause appears to be that _hostVolumeDao is null during execution. The root cause is that the HostVolumeDao is missing the @Inject annotation.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/vm/UserVmManagerImpl.java 87d88a4 
> 
> Diff: https://reviews.apache.org/r/5834/diff/
> 
> 
> Testing
> -------
> 
> clean-all build-all deploy-server
> 
> create volume and attach to existing host.. success
> 
> 
> Thanks,
> 
> Hugo Trippaers
> 
>