[GitHub] [incubator-doris] wangbo commented on a diff in pull request #9112: [Bug][Storage-vectorized] fix code dump on outer join with not nullable column

[GitBox <gi...@apache.org>]

wangbo commented on code in PR #9112:
URL: https://github.com/apache/incubator-doris/pull/9112#discussion_r853695757


##########
be/src/vec/columns/predicate_column.h:
##########
@@ -348,6 +349,13 @@ class PredicateColumnType final : public COWHelper<IColumn, PredicateColumnType<
     }
 
     Status filter_by_selector(const uint16_t* sel, size_t sel_size, IColumn* col_ptr) override {
+        if (col_ptr->is_nullable()) {

Review Comment:
   Move this Nullable judgement to block.
   PredicateColumn should not this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org