You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/03/06 21:37:46 UTC
[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancign Algorithm
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9515
Change subject: [DOCS] Publish Choosing the Load-Balancign Algorithm
......................................................................
[DOCS] Publish Choosing the Load-Balancign Algorithm
Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
---
M docs/topics/impala_proxy.xml
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/9515/1
--
To view, visit http://gerrit.cloudera.org:8080/9515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
Gerrit-Change-Number: 9515
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancing Algorithm topic
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9515 )
Change subject: [DOCS] Publish Choosing the Load-Balancing Algorithm topic
......................................................................
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/213/
--
To view, visit http://gerrit.cloudera.org:8080/9515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
Gerrit-Change-Number: 9515
Gerrit-PatchSet: 7
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #381
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Mar 2018 16:35:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancing Algorithm topic
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9515 )
Change subject: [DOCS] Publish Choosing the Load-Balancing Algorithm topic
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9515/4/docs/topics/impala_proxy.xml
File docs/topics/impala_proxy.xml:
http://gerrit.cloudera.org:8080/#/c/9515/4/docs/topics/impala_proxy.xml@204
PS4, Line 204: Recommended
> Maybe a even stronger word like "Hue must use sticky session."
Alan,
Could you advise how I can reconcile the sentence before that says source affinity is a better choice for Hue sessions with this?
--
To view, visit http://gerrit.cloudera.org:8080/9515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
Gerrit-Change-Number: 9515
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #381
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Mar 2018 00:27:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancign Algorithm
Posted by "Fredy Wijaya (Code Review)" <ge...@cloudera.org>.
Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/9515 )
Change subject: [DOCS] Publish Choosing the Load-Balancign Algorithm
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9515/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9515/3//COMMIT_MSG@7
PS3, Line 7: [DOCS] Publish Choosing the Load-Balancign Algorithm
Typo in balancing.
--
To view, visit http://gerrit.cloudera.org:8080/9515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
Gerrit-Change-Number: 9515
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Mar 2018 23:06:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancing Algorithm topic
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9515 )
Change subject: [DOCS] Publish Choosing the Load-Balancing Algorithm topic
......................................................................
Patch Set 6:
Could someone please review and approve the latest patch?
--
To view, visit http://gerrit.cloudera.org:8080/9515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
Gerrit-Change-Number: 9515
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #381
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Mar 2018 04:08:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancing Algorithm topic
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello John Russell, Fredy Wijaya, Alan Choi, Anonymous Coward #381, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9515
to look at the new patch set (#5).
Change subject: [DOCS] Publish Choosing the Load-Balancing Algorithm topic
......................................................................
[DOCS] Publish Choosing the Load-Balancing Algorithm topic
Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
---
M docs/topics/impala_proxy.xml
1 file changed, 189 insertions(+), 150 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/9515/5
--
To view, visit http://gerrit.cloudera.org:8080/9515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
Gerrit-Change-Number: 9515
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #381
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancing Algorithm topic
Posted by "Alan Choi (Code Review)" <ge...@cloudera.org>.
Alan Choi has posted comments on this change. ( http://gerrit.cloudera.org:8080/9515 )
Change subject: [DOCS] Publish Choosing the Load-Balancing Algorithm topic
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9515/4/docs/topics/impala_proxy.xml
File docs/topics/impala_proxy.xml:
http://gerrit.cloudera.org:8080/#/c/9515/4/docs/topics/impala_proxy.xml@204
PS4, Line 204: Recommended
> Alan,
I was not aware of that. Can you ask Hue team to comment on it?
--
To view, visit http://gerrit.cloudera.org:8080/9515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
Gerrit-Change-Number: 9515
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #381
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Mar 2018 01:27:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancing Algorithm topic
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9515 )
Change subject: [DOCS] Publish Choosing the Load-Balancing Algorithm topic
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
Gerrit-Change-Number: 9515
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #381
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Mar 2018 16:35:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancing Algorithm topic
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9515 )
Change subject: [DOCS] Publish Choosing the Load-Balancing Algorithm topic
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9515/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/9515/3//COMMIT_MSG@7
PS3, Line 7: [DOCS] Publish Choosing the Load-Balancign Algorithm
> Typo in balancing.
Done
--
To view, visit http://gerrit.cloudera.org:8080/9515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
Gerrit-Change-Number: 9515
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Mar 2018 23:27:41 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancing Algorithm topic
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9515 )
Change subject: [DOCS] Publish Choosing the Load-Balancing Algorithm topic
......................................................................
Patch Set 4:
> (1 comment)
Comment from the Hue team:
I am not familiar with sticky, we recommend 'source' http://gethue.com/how-to-optimally-configure-your-analytic-database-for-high-availability-with-hue-and-other-sql-clients/
--
To view, visit http://gerrit.cloudera.org:8080/9515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
Gerrit-Change-Number: 9515
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #381
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Mar 2018 18:15:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancing Algorithm topic
Posted by "Alan Choi (Code Review)" <ge...@cloudera.org>.
Alan Choi has posted comments on this change. ( http://gerrit.cloudera.org:8080/9515 )
Change subject: [DOCS] Publish Choosing the Load-Balancing Algorithm topic
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9515/4/docs/topics/impala_proxy.xml
File docs/topics/impala_proxy.xml:
http://gerrit.cloudera.org:8080/#/c/9515/4/docs/topics/impala_proxy.xml@204
PS4, Line 204: Recommended
Maybe a even stronger word like "Hue must use sticky session."
--
To view, visit http://gerrit.cloudera.org:8080/9515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
Gerrit-Change-Number: 9515
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Mar 2018 00:43:11 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancing Algorithm topic
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9515 )
Change subject: [DOCS] Publish Choosing the Load-Balancing Algorithm topic
......................................................................
Patch Set 4:
(1 comment)
Ready for +2 after incorporating Alan's final suggestion.
http://gerrit.cloudera.org:8080/#/c/9515/4/docs/topics/impala_proxy.xml
File docs/topics/impala_proxy.xml:
http://gerrit.cloudera.org:8080/#/c/9515/4/docs/topics/impala_proxy.xml@204
PS4, Line 204: Recommended
> Maybe a even stronger word like "Hue must use sticky session."
I agree, strengthening the wording will probably head off some more support calls.
--
To view, visit http://gerrit.cloudera.org:8080/9515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
Gerrit-Change-Number: 9515
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Mar 2018 23:15:02 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancign Algorithm
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9515 )
Change subject: [DOCS] Publish Choosing the Load-Balancign Algorithm
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9515/1/docs/topics/impala_proxy.xml
File docs/topics/impala_proxy.xml:
http://gerrit.cloudera.org:8080/#/c/9515/1/docs/topics/impala_proxy.xml@173
PS1, Line 173: leastconn
> This makes sense for Impala. We recommend leastconn for F5.
Done
--
To view, visit http://gerrit.cloudera.org:8080/9515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
Gerrit-Change-Number: 9515
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Mar 2018 22:44:17 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancing Algorithm topic
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9515 )
Change subject: [DOCS] Publish Choosing the Load-Balancing Algorithm topic
......................................................................
[DOCS] Publish Choosing the Load-Balancing Algorithm topic
Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
Reviewed-on: http://gerrit.cloudera.org:8080/9515
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_proxy.xml
1 file changed, 16 insertions(+), 16 deletions(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/9515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
Gerrit-Change-Number: 9515
Gerrit-PatchSet: 8
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #381
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancign Algorithm
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/9515 )
Change subject: [DOCS] Publish Choosing the Load-Balancign Algorithm
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/9515/1/docs/topics/impala_proxy.xml
File docs/topics/impala_proxy.xml:
http://gerrit.cloudera.org:8080/#/c/9515/1/docs/topics/impala_proxy.xml@162
PS1, Line 162: <concept id="proxy_balancing" rev="">
> Do you happen to know why it was hidden to begin with?
John Russel was waiting for reviews.
http://gerrit.cloudera.org:8080/#/c/9515/1/docs/topics/impala_proxy.xml@195
PS1, Line 195: Recommended for use with Hue.
> Hue requires sticky, not "source affinity".
Done
--
To view, visit http://gerrit.cloudera.org:8080/9515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
Gerrit-Change-Number: 9515
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Mar 2018 22:42:18 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancing Algorithm topic
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9515 )
Change subject: [DOCS] Publish Choosing the Load-Balancing Algorithm topic
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
Gerrit-Change-Number: 9515
Gerrit-PatchSet: 7
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #381
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Mar 2018 16:35:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancing Algorithm topic
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/9515 )
Change subject: [DOCS] Publish Choosing the Load-Balancing Algorithm topic
......................................................................
Patch Set 7: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/9515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
Gerrit-Change-Number: 9515
Gerrit-PatchSet: 7
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #381
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Mar 2018 17:04:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancing Algorithm topic
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello John Russell, Fredy Wijaya, Alan Choi, Anonymous Coward #381, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9515
to look at the new patch set (#6).
Change subject: [DOCS] Publish Choosing the Load-Balancing Algorithm topic
......................................................................
[DOCS] Publish Choosing the Load-Balancing Algorithm topic
Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
---
M docs/topics/impala_proxy.xml
1 file changed, 16 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/9515/6
--
To view, visit http://gerrit.cloudera.org:8080/9515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
Gerrit-Change-Number: 9515
Gerrit-PatchSet: 6
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward #381
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancign Algorithm
Posted by "Alan Choi (Code Review)" <ge...@cloudera.org>.
Alan Choi has posted comments on this change. ( http://gerrit.cloudera.org:8080/9515 )
Change subject: [DOCS] Publish Choosing the Load-Balancign Algorithm
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/9515/1/docs/topics/impala_proxy.xml
File docs/topics/impala_proxy.xml:
http://gerrit.cloudera.org:8080/#/c/9515/1/docs/topics/impala_proxy.xml@162
PS1, Line 162: <concept id="proxy_balancing" rev="">
Do you happen to know why it was hidden to begin with?
http://gerrit.cloudera.org:8080/#/c/9515/1/docs/topics/impala_proxy.xml@173
PS1, Line 173: leastconn
This makes sense for Impala. We recommend leastconn for F5.
http://www.cloudera.com/documentation/other/reference-architecture/PDF/Impala-HA-with-F5-BIG-IP.pdf
http://gerrit.cloudera.org:8080/#/c/9515/1/docs/topics/impala_proxy.xml@195
PS1, Line 195: Recommended for use with Hue.
Hue requires sticky, not "source affinity".
--
To view, visit http://gerrit.cloudera.org:8080/9515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
Gerrit-Change-Number: 9515
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Mar 2018 22:32:57 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancing Algorithm topic
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello John Russell, Fredy Wijaya, Alan Choi,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9515
to look at the new patch set (#4).
Change subject: [DOCS] Publish Choosing the Load-Balancing Algorithm topic
......................................................................
[DOCS] Publish Choosing the Load-Balancing Algorithm topic
Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
---
M docs/topics/impala_proxy.xml
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/9515/4
--
To view, visit http://gerrit.cloudera.org:8080/9515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
Gerrit-Change-Number: 9515
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancign Algorithm
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello John Russell, Alan Choi,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9515
to look at the new patch set (#3).
Change subject: [DOCS] Publish Choosing the Load-Balancign Algorithm
......................................................................
[DOCS] Publish Choosing the Load-Balancign Algorithm
Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
---
M docs/topics/impala_proxy.xml
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/9515/3
--
To view, visit http://gerrit.cloudera.org:8080/9515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
Gerrit-Change-Number: 9515
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancing Algorithm topic
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/9515 )
Change subject: [DOCS] Publish Choosing the Load-Balancing Algorithm topic
......................................................................
Patch Set 1:
(1 comment)
Just an FYI to Alex's response on Alan's question.
http://gerrit.cloudera.org:8080/#/c/9515/1/docs/topics/impala_proxy.xml
File docs/topics/impala_proxy.xml:
http://gerrit.cloudera.org:8080/#/c/9515/1/docs/topics/impala_proxy.xml@162
PS1, Line 162: <concept id="proxy_balancing" rev="">
> John Russel was waiting for reviews.
Yes, it slipped through the cracks while moving doc development to upstream. Especially because if we started going into a lot of detail about using Impala with <commercial load balancer X>, that could arguably be inappropriate to include in upstream docs.
--
To view, visit http://gerrit.cloudera.org:8080/9515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
Gerrit-Change-Number: 9515
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fw...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Mar 2018 00:23:11 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Publish Choosing the Load-Balancign Algorithm
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello John Russell, Alan Choi,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9515
to look at the new patch set (#2).
Change subject: [DOCS] Publish Choosing the Load-Balancign Algorithm
......................................................................
[DOCS] Publish Choosing the Load-Balancign Algorithm
Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
---
M docs/topics/impala_proxy.xml
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/15/9515/2
--
To view, visit http://gerrit.cloudera.org:8080/9515
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7c29ddac53c0fb4cc6a297444401e50280b95167
Gerrit-Change-Number: 9515
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alan Choi <al...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>