You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2017/05/30 23:17:52 UTC
Review Request 59667: Reordered the methods in `Framework` into logic
units.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59667/
-----------------------------------------------------------
Review request for mesos, Anand Mazumdar and Vinod Kone.
Repository: mesos
Description
-------
Also, make sure the order in the header is in sync with that in the
corresponding source file.
Diffs
-----
src/slave/slave.hpp 77fb93abc701cd34b69c75b6219c219fdb784a67
src/slave/slave.cpp 055e4967a4c820d7835f5fecdc46f82eaddd9117
Diff: https://reviews.apache.org/r/59667/diff/1/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 59667: Reordered the methods in `Framework` into
logic units.
Posted by Anand Mazumdar <an...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59667/#review176473
-----------------------------------------------------------
Fix it, then Ship it!
src/slave/slave.cpp
Lines 4885 (patched)
<https://reviews.apache.org/r/59667/#comment249828>
Can you update the summary/description given that it also reorders methods in the `Slave` struct?
src/slave/slave.cpp
Line 6971 (original), 6991 (patched)
<https://reviews.apache.org/r/59667/#comment249829>
Move this above `checkpointFramework()`?
- Anand Mazumdar
On May 30, 2017, 11:17 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59667/
> -----------------------------------------------------------
>
> (Updated May 30, 2017, 11:17 p.m.)
>
>
> Review request for mesos, Anand Mazumdar and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Also, make sure the order in the header is in sync with that in the
> corresponding source file.
>
>
> Diffs
> -----
>
> src/slave/slave.hpp 77fb93abc701cd34b69c75b6219c219fdb784a67
> src/slave/slave.cpp 055e4967a4c820d7835f5fecdc46f82eaddd9117
>
>
> Diff: https://reviews.apache.org/r/59667/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>