You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/22 14:55:50 UTC
[GitHub] [arrow] lidavidm opened a new pull request #8241: ARROW-10054: [C++][Python] don't crash when slice offset > length
lidavidm opened a new pull request #8241:
URL: https://github.com/apache/arrow/pull/8241
Instead of crashing using a CHECK, adjust the offset so that the caller gets an empty array, matching expectations for Python users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm commented on pull request #8241: ARROW-10054: [C++][Python] don't crash when slice offset > length
Posted by GitBox <gi...@apache.org>.
wesm commented on pull request #8241:
URL: https://github.com/apache/arrow/pull/8241#issuecomment-701540108
Another option is to add a `SliceSafe` that returns `Result`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8241: ARROW-10054: [C++][Python] don't crash when slice offset > length
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8241:
URL: https://github.com/apache/arrow/pull/8241#issuecomment-696821164
https://issues.apache.org/jira/browse/ARROW-10054
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #8241: ARROW-10054: [C++][Python] don't crash when slice offset > length
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #8241:
URL: https://github.com/apache/arrow/pull/8241#issuecomment-701571544
Ok. On the C++ I'm hesitant to add new APIs it's unclear whether they're useful; on the Python side I'll make the checking more consistent to avoid crashing/match Python expectations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #8241: ARROW-10054: [C++][Python] don't crash when slice offset > length
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #8241:
URL: https://github.com/apache/arrow/pull/8241#issuecomment-701379367
> I'm not sure we want this behaviour on the C++ side, as opposed to check arguments on the Python side. @wesm what do you think?
That would also make sense - I think the Python side already does some checking, just not uniformly. Happy to rework it if Wes agrees.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] wesm closed pull request #8241: ARROW-10054: [Python] don't crash when slice offset > length
Posted by GitBox <gi...@apache.org>.
wesm closed pull request #8241:
URL: https://github.com/apache/arrow/pull/8241
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8241: ARROW-10054: [C++][Python] don't crash when slice offset > length
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8241:
URL: https://github.com/apache/arrow/pull/8241#issuecomment-696821164
https://issues.apache.org/jira/browse/ARROW-10054
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #8241: ARROW-10054: [Python] don't crash when slice offset > length
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #8241:
URL: https://github.com/apache/arrow/pull/8241#issuecomment-702298958
Alright, this is now purely a Python PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #8241: ARROW-10054: [C++][Python] don't crash when slice offset > length
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8241:
URL: https://github.com/apache/arrow/pull/8241#issuecomment-701358197
I'm not sure we want this behaviour on the C++ side, as opposed to check arguments on the Python side. @wesm what do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org