You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Santhosh Edukulla <sa...@citrix.com> on 2014/05/08 12:48:21 UTC
Review Request 21200: Added Fix for CLOUDSTACK-6548
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21200/
-----------------------------------------------------------
Review request for cloudstack and daan Hoogland.
Bugs: CLOUDSTACK-6548
https://issues.apache.org/jira/browse/CLOUDSTACK-6548
Repository: cloudstack-git
Description
-------
1. Fixed a regression issue introduced for createPrivateNetwork
2. Mentioned test case "integration.smoke.test_privategw_acl.TestPrivateGwACL.test_privategw_acl", post the fix
was working fine. Below is the attached log.
3. Ran the checkstyle check
Diffs
-----
server/src/com/cloud/network/NetworkServiceImpl.java 05c2725
server/src/com/cloud/network/vpc/VpcManagerImpl.java ad078fc
Diff: https://reviews.apache.org/r/21200/diff/
Testing
-------
test_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_privategw_acl | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 127.279s
OK
~
~
~
~
Thanks,
Santhosh Edukulla
Re: Review Request 21200: Added Fix for CLOUDSTACK-6548
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21200/#review42570
-----------------------------------------------------------
Commit 550493cec318a7ab2c0d5376183263ef2efba58e in cloudstack's branch refs/heads/4.4-forward from santhosh
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=550493c ]
Added fix for CLOUDSTACK-6548
Signed-off-by: santhosh <sa...@gmail.com>
Signed-off-by: Daan Hoogland <da...@onecht.net>
- ASF Subversion and Git Services
On May 8, 2014, 10:48 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21200/
> -----------------------------------------------------------
>
> (Updated May 8, 2014, 10:48 a.m.)
>
>
> Review request for cloudstack and daan Hoogland.
>
>
> Bugs: CLOUDSTACK-6548
> https://issues.apache.org/jira/browse/CLOUDSTACK-6548
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Fixed a regression issue introduced for createPrivateNetwork
> 2. Mentioned test case "integration.smoke.test_privategw_acl.TestPrivateGwACL.test_privategw_acl", post the fix
> was working fine. Below is the attached log.
> 3. Ran the checkstyle check
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkServiceImpl.java 05c2725
> server/src/com/cloud/network/vpc/VpcManagerImpl.java ad078fc
>
> Diff: https://reviews.apache.org/r/21200/diff/
>
>
> Testing
> -------
>
> test_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_privategw_acl | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 127.279s
>
> OK
> ~
> ~
> ~
> ~
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 21200: Added Fix for CLOUDSTACK-6548
Posted by daan Hoogland <da...@gmail.com>.
> On May 9, 2014, 3:07 p.m., daan Hoogland wrote:
> > 550493cec318a7ab2c0d5376183263ef2efba58e on 4.4 forward
00fcd9fb20009566b61a205c1eec28a65ea574db on master
- daan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21200/#review42571
-----------------------------------------------------------
On May 8, 2014, 10:48 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21200/
> -----------------------------------------------------------
>
> (Updated May 8, 2014, 10:48 a.m.)
>
>
> Review request for cloudstack and daan Hoogland.
>
>
> Bugs: CLOUDSTACK-6548
> https://issues.apache.org/jira/browse/CLOUDSTACK-6548
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Fixed a regression issue introduced for createPrivateNetwork
> 2. Mentioned test case "integration.smoke.test_privategw_acl.TestPrivateGwACL.test_privategw_acl", post the fix
> was working fine. Below is the attached log.
> 3. Ran the checkstyle check
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkServiceImpl.java 05c2725
> server/src/com/cloud/network/vpc/VpcManagerImpl.java ad078fc
>
> Diff: https://reviews.apache.org/r/21200/diff/
>
>
> Testing
> -------
>
> test_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_privategw_acl | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 127.279s
>
> OK
> ~
> ~
> ~
> ~
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 21200: Added Fix for CLOUDSTACK-6548
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21200/#review42571
-----------------------------------------------------------
Ship it!
550493cec318a7ab2c0d5376183263ef2efba58e on 4.4 forward
- daan Hoogland
On May 8, 2014, 10:48 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21200/
> -----------------------------------------------------------
>
> (Updated May 8, 2014, 10:48 a.m.)
>
>
> Review request for cloudstack and daan Hoogland.
>
>
> Bugs: CLOUDSTACK-6548
> https://issues.apache.org/jira/browse/CLOUDSTACK-6548
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Fixed a regression issue introduced for createPrivateNetwork
> 2. Mentioned test case "integration.smoke.test_privategw_acl.TestPrivateGwACL.test_privategw_acl", post the fix
> was working fine. Below is the attached log.
> 3. Ran the checkstyle check
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkServiceImpl.java 05c2725
> server/src/com/cloud/network/vpc/VpcManagerImpl.java ad078fc
>
> Diff: https://reviews.apache.org/r/21200/diff/
>
>
> Testing
> -------
>
> test_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_privategw_acl | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 127.279s
>
> OK
> ~
> ~
> ~
> ~
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 21200: Added Fix for CLOUDSTACK-6548
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21200/#review42572
-----------------------------------------------------------
Commit 32124df53cf9023507180c8509b6f41f29e9c4ae in cloudstack's branch refs/heads/4.4 from santhosh
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=32124df ]
Added fix for CLOUDSTACK-6548
Signed-off-by: santhosh <sa...@gmail.com>
Signed-off-by: Daan Hoogland <da...@onecht.net>
- ASF Subversion and Git Services
On May 8, 2014, 10:48 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21200/
> -----------------------------------------------------------
>
> (Updated May 8, 2014, 10:48 a.m.)
>
>
> Review request for cloudstack and daan Hoogland.
>
>
> Bugs: CLOUDSTACK-6548
> https://issues.apache.org/jira/browse/CLOUDSTACK-6548
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Fixed a regression issue introduced for createPrivateNetwork
> 2. Mentioned test case "integration.smoke.test_privategw_acl.TestPrivateGwACL.test_privategw_acl", post the fix
> was working fine. Below is the attached log.
> 3. Ran the checkstyle check
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkServiceImpl.java 05c2725
> server/src/com/cloud/network/vpc/VpcManagerImpl.java ad078fc
>
> Diff: https://reviews.apache.org/r/21200/diff/
>
>
> Testing
> -------
>
> test_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_privategw_acl | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 127.279s
>
> OK
> ~
> ~
> ~
> ~
>
>
> Thanks,
>
> Santhosh Edukulla
>
>
Re: Review Request 21200: Added Fix for CLOUDSTACK-6548
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21200/#review42573
-----------------------------------------------------------
Commit 00fcd9fb20009566b61a205c1eec28a65ea574db in cloudstack's branch refs/heads/master from santhosh
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=00fcd9f ]
Added fix for CLOUDSTACK-6548
Signed-off-by: santhosh <sa...@gmail.com>
Signed-off-by: Daan Hoogland <da...@onecht.net>
Conflicts:
server/src/com/cloud/network/NetworkServiceImpl.java
- ASF Subversion and Git Services
On May 8, 2014, 10:48 a.m., Santhosh Edukulla wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21200/
> -----------------------------------------------------------
>
> (Updated May 8, 2014, 10:48 a.m.)
>
>
> Review request for cloudstack and daan Hoogland.
>
>
> Bugs: CLOUDSTACK-6548
> https://issues.apache.org/jira/browse/CLOUDSTACK-6548
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. Fixed a regression issue introduced for createPrivateNetwork
> 2. Mentioned test case "integration.smoke.test_privategw_acl.TestPrivateGwACL.test_privategw_acl", post the fix
> was working fine. Below is the attached log.
> 3. Ran the checkstyle check
>
>
> Diffs
> -----
>
> server/src/com/cloud/network/NetworkServiceImpl.java 05c2725
> server/src/com/cloud/network/vpc/VpcManagerImpl.java ad078fc
>
> Diff: https://reviews.apache.org/r/21200/diff/
>
>
> Testing
> -------
>
> test_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) ... === TestName: test_privategw_acl | Status : SUCCESS ===
> ok
>
> ----------------------------------------------------------------------
> Ran 1 test in 127.279s
>
> OK
> ~
> ~
> ~
> ~
>
>
> Thanks,
>
> Santhosh Edukulla
>
>