You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/04 00:12:42 UTC
[GitHub] [incubator-superset] geido opened a new pull request #12218: refactor: Enhance control panel Collapse
geido opened a new pull request #12218:
URL: https://github.com/apache/incubator-superset/pull/12218
### SUMMARY
Removes react-bootstrap Collapse with Antdesign enhanced Collapse.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
<img width="421" alt="before" src="https://user-images.githubusercontent.com/60598000/103233962-1b08cf80-4947-11eb-8641-d594403e7e46.png">
After:
<img width="419" alt="after" src="https://user-images.githubusercontent.com/60598000/103233969-20661a00-4947-11eb-9ab6-f6cb5bcc5f83.png">
### TEST PLAN
1. Open the explorer
2. Make sure the control panel has all the collapsible expanded
3. Close a collapsible panel, the content should be hidden
4. Re-open the closed collapsible panel, the content should appear
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [x] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc commented on pull request #12218: refactor: Enhance control panel Collapse
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #12218:
URL: https://github.com/apache/incubator-superset/pull/12218#issuecomment-753393024
thanks @geido for the PR. if the caret was the only thing that changed, it LGTM. but im not sure why the tabs in the control panel got messed up a bit...
<img width="257" alt="Screen Shot 2021-01-01 at 2 10 13 PM" src="https://user-images.githubusercontent.com/67837651/103447054-1d1aa900-4c3b-11eb-8443-9f8b98a44070.png">
this is what im seeing and how it supposed to look in another open PR
<img width="622" alt="Screen Shot 2021-01-01 at 2 11 47 PM" src="https://user-images.githubusercontent.com/67837651/103447104-9b774b00-4c3b-11eb-8bd0-3813d074781f.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch closed pull request #12218: refactor: Enhance control panel Collapse
Posted by GitBox <gi...@apache.org>.
mistercrunch closed pull request #12218:
URL: https://github.com/apache/incubator-superset/pull/12218
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] geido edited a comment on pull request #12218: refactor: Enhance control panel Collapse
Posted by GitBox <gi...@apache.org>.
geido edited a comment on pull request #12218:
URL: https://github.com/apache/incubator-superset/pull/12218#issuecomment-753393329
Thanks @junlincc. Let me check what might have caused that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] geido commented on pull request #12218: refactor: Enhance control panel Collapse
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #12218:
URL: https://github.com/apache/incubator-superset/pull/12218#issuecomment-753393329
> thanks @geido for the PR. if the caret was the only thing that changed, it LGTM. but im not sure why the tabs in the control panel got messed up a bit...
> <img width="257" alt="Screen Shot 2021-01-01 at 2 10 13 PM" src="https://user-images.githubusercontent.com/67837651/103447054-1d1aa900-4c3b-11eb-8443-9f8b98a44070.png">
> this is what im seeing and how it supposed to look in another open PR
>
>
> <img width="622" alt="Screen Shot 2021-01-01 at 2 11 47 PM" src="https://user-images.githubusercontent.com/67837651/103447104-9b774b00-4c3b-11eb-8bd0-3813d074781f.png">
>
Thanks @junlincc. Let me check what might have caused that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] geido closed pull request #12218: refactor: Enhance control panel Collapse
Posted by GitBox <gi...@apache.org>.
geido closed pull request #12218:
URL: https://github.com/apache/incubator-superset/pull/12218
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] geido commented on pull request #12218: refactor: Enhance control panel Collapse
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #12218:
URL: https://github.com/apache/incubator-superset/pull/12218#issuecomment-754108077
@junlincc Please check now. The issue should be resolved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] geido commented on pull request #12218: refactor: Enhance control panel Collapse
Posted by GitBox <gi...@apache.org>.
geido commented on pull request #12218:
URL: https://github.com/apache/incubator-superset/pull/12218#issuecomment-751820864
@rusackas @junlincc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] junlincc edited a comment on pull request #12218: refactor: Enhance control panel Collapse
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #12218:
URL: https://github.com/apache/incubator-superset/pull/12218#issuecomment-753393024
thanks @geido for the PR. if the caret was the only thing that changed, it LGTM. but im not sure why the tabs in the control panel got messed up a bit...
<img width="257" alt="Screen Shot 2021-01-01 at 2 10 13 PM" src="https://user-images.githubusercontent.com/67837651/103447054-1d1aa900-4c3b-11eb-8443-9f8b98a44070.png">
this is what im seeing and how it supposed to look in another open PR
<img width="622" alt="Screen Shot 2021-01-01 at 2 11 47 PM" src="https://user-images.githubusercontent.com/67837651/103447104-9b774b00-4c3b-11eb-8bd0-3813d074781f.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org