You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2020/03/17 07:24:09 UTC
[GitHub] [carbondata] jackylk opened a new pull request #3671:
[CARBONDATA-3742] support spark 2.4.5
jackylk opened a new pull request #3671: [CARBONDATA-3742] support spark 2.4.5
URL: https://github.com/apache/carbondata/pull/3671
### Why is this PR needed?
Currently CarbonData does not support integration with spark 2.4.5
### What changes were proposed in this PR?
Support integration with spark 2.4.5
### Does this PR introduce any user interface change?
- No
### Is any new testcase added?
- No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] jackylk commented on a change in pull request #3671:
[CARBONDATA-3742] Support spark 2.4.5 integration
Posted by GitBox <gi...@apache.org>.
jackylk commented on a change in pull request #3671: [CARBONDATA-3742] Support spark 2.4.5 integration
URL: https://github.com/apache/carbondata/pull/3671#discussion_r395659568
##########
File path: docs/prestodb-guide.md
##########
@@ -238,10 +238,10 @@ Now you can use the Presto CLI on the coordinator to query data sources in the c
```
Replace the spark and hadoop version with the version used in your cluster.
For example, use prestodb profile and
- if you are using Spark 2.4.4, you would like to compile using:
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3671:
[CARBONDATA-3742] support spark 2.4.5
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3671: [CARBONDATA-3742] support spark 2.4.5
URL: https://github.com/apache/carbondata/pull/3671#issuecomment-600464082
Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/791/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ajantha-bhat commented on a change in pull request
#3671: [CARBONDATA-3742] Support spark 2.4.5 integration
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on a change in pull request #3671: [CARBONDATA-3742] Support spark 2.4.5 integration
URL: https://github.com/apache/carbondata/pull/3671#discussion_r394852666
##########
File path: integration/spark/src/main/scala/org/apache/spark/util/CarbonReflectionUtils.scala
##########
@@ -31,7 +31,7 @@ import org.apache.spark.sql.catalyst.expressions.{Attribute, AttributeReference,
import org.apache.spark.sql.catalyst.parser.AstBuilder
Review comment:
unused import ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3671:
[CARBONDATA-3742] support spark 2.4.5
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3671: [CARBONDATA-3742] support spark 2.4.5
URL: https://github.com/apache/carbondata/pull/3671#issuecomment-600021603
Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/781/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ajantha-bhat commented on issue #3671:
[CARBONDATA-3742] Support spark 2.4.5 integration
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on issue #3671: [CARBONDATA-3742] Support spark 2.4.5 integration
URL: https://github.com/apache/carbondata/pull/3671#issuecomment-602035212
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3671:
[CARBONDATA-3742] support spark 2.4.5
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3671: [CARBONDATA-3742] support spark 2.4.5
URL: https://github.com/apache/carbondata/pull/3671#issuecomment-600463934
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2496/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3671:
[CARBONDATA-3742] Support spark 2.4.5 integration
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3671: [CARBONDATA-3742] Support spark 2.4.5 integration
URL: https://github.com/apache/carbondata/pull/3671#issuecomment-602053462
Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/828/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ajantha-bhat commented on issue #3671:
[CARBONDATA-3742] Support spark 2.4.5 integration
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on issue #3671: [CARBONDATA-3742] Support spark 2.4.5 integration
URL: https://github.com/apache/carbondata/pull/3671#issuecomment-601046745
Once it is merged, we can rename the PR builder also to Spark 2.4.5
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ajantha-bhat commented on a change in pull request
#3671: [CARBONDATA-3742] Support spark 2.4.5 integration
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on a change in pull request #3671: [CARBONDATA-3742] Support spark 2.4.5 integration
URL: https://github.com/apache/carbondata/pull/3671#discussion_r394851181
##########
File path: docs/prestodb-guide.md
##########
@@ -238,10 +238,10 @@ Now you can use the Presto CLI on the coordinator to query data sources in the c
```
Replace the spark and hadoop version with the version used in your cluster.
For example, use prestodb profile and
- if you are using Spark 2.4.4, you would like to compile using:
Review comment:
prestosql-guide also has this.
please look up 2.4.4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3671:
[CARBONDATA-3742] Support spark 2.4.5 integration
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3671: [CARBONDATA-3742] Support spark 2.4.5 integration
URL: https://github.com/apache/carbondata/pull/3671#issuecomment-601814485
Build Failed with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/819/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3671:
[CARBONDATA-3742] Support spark 2.4.5 integration
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3671: [CARBONDATA-3742] Support spark 2.4.5 integration
URL: https://github.com/apache/carbondata/pull/3671#issuecomment-601788610
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2526/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3671:
[CARBONDATA-3742] support spark 2.4.5
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3671: [CARBONDATA-3742] support spark 2.4.5
URL: https://github.com/apache/carbondata/pull/3671#issuecomment-600008923
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2487/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] ajantha-bhat commented on issue #3671:
[CARBONDATA-3742] Support spark 2.4.5 integration
Posted by GitBox <gi...@apache.org>.
ajantha-bhat commented on issue #3671: [CARBONDATA-3742] Support spark 2.4.5 integration
URL: https://github.com/apache/carbondata/pull/3671#issuecomment-602134399
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] jackylk commented on a change in pull request #3671:
[CARBONDATA-3742] Support spark 2.4.5 integration
Posted by GitBox <gi...@apache.org>.
jackylk commented on a change in pull request #3671: [CARBONDATA-3742] Support spark 2.4.5 integration
URL: https://github.com/apache/carbondata/pull/3671#discussion_r395659862
##########
File path: integration/spark/src/main/scala/org/apache/spark/util/CarbonReflectionUtils.scala
##########
@@ -31,7 +31,7 @@ import org.apache.spark.sql.catalyst.expressions.{Attribute, AttributeReference,
import org.apache.spark.sql.catalyst.parser.AstBuilder
Review comment:
removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3671:
[CARBONDATA-3742] Support spark 2.4.5 integration
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3671: [CARBONDATA-3742] Support spark 2.4.5 integration
URL: https://github.com/apache/carbondata/pull/3671#issuecomment-602049958
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2535/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] asfgit closed pull request #3671: [CARBONDATA-3742]
Support spark 2.4.5 integration
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3671: [CARBONDATA-3742] Support spark 2.4.5 integration
URL: https://github.com/apache/carbondata/pull/3671
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] jackylk commented on issue #3671: [CARBONDATA-3742]
support spark 2.4.5
Posted by GitBox <gi...@apache.org>.
jackylk commented on issue #3671: [CARBONDATA-3742] support spark 2.4.5
URL: https://github.com/apache/carbondata/pull/3671#issuecomment-600425060
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3671:
[CARBONDATA-3742] support spark 2.4.5
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3671: [CARBONDATA-3742] support spark 2.4.5
URL: https://github.com/apache/carbondata/pull/3671#issuecomment-599917799
Build Failed with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/778/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services