You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2018/01/23 17:35:42 UTC
[GitHub] markusthoemmes commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110
markusthoemmes commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110
URL: https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r163319973
##########
File path: core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerContainerFactory.scala
##########
@@ -126,6 +129,13 @@ object DockerContainerFactoryProvider extends ContainerFactoryProvider {
logging: Logging,
config: WhiskConfig,
instanceId: InstanceId,
- parameters: Map[String, Set[String]]): ContainerFactory =
- new DockerContainerFactory(config, instanceId, parameters)(actorSystem, actorSystem.dispatcher, logging)
+ parameters: Map[String, Set[String]]): ContainerFactory = {
+
+ new DockerContainerFactory(config, instanceId, parameters, dockerApiFactory)(
+ actorSystem,
+ actorSystem.dispatcher,
+ logging)
+ }
+ def dockerApiFactory(actorSystem: ActorSystem, logging: Logging) =
Review comment:
Why pull this out to a seperate function?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services