You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ca...@apache.org on 2020/04/29 13:59:28 UTC
[royale-asjs] branch develop updated: jewel-searchfilter: refactor
list listeners to functions to make it more easy to extend
This is an automated email from the ASF dual-hosted git repository.
carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new 1d93fec jewel-searchfilter: refactor list listeners to functions to make it more easy to extend
1d93fec is described below
commit 1d93fec742c08b36a2c5ca588537a52fbf989ecb
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Wed Apr 29 15:59:23 2020 +0200
jewel-searchfilter: refactor list listeners to functions to make it more easy to extend
---
.../jewel/beads/controls/combobox/SearchFilter.as | 2 +-
.../beads/controls/textinput/SearchFilterForList.as | 18 +++++++++++-------
2 files changed, 12 insertions(+), 8 deletions(-)
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/combobox/SearchFilter.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/combobox/SearchFilter.as
index f8ebdb5..f815310 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/combobox/SearchFilter.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/combobox/SearchFilter.as
@@ -81,7 +81,7 @@ package org.apache.royale.jewel.beads.controls.combobox
}
override protected function onBeadsAdded(event:Event):void{
- IEventDispatcher(_strand).addEventListener('dismissPopUp', removeKeyDownEventListener);
+ IEventDispatcher(_strand).addEventListener('dismissPopUp', removeListListeners);
comboView = event.target.view as IComboBoxView;
if (comboView)
diff --git a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/textinput/SearchFilterForList.as b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/textinput/SearchFilterForList.as
index da51dfe..d39fdbe 100644
--- a/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/textinput/SearchFilterForList.as
+++ b/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/textinput/SearchFilterForList.as
@@ -71,16 +71,11 @@ package org.apache.royale.jewel.beads.controls.textinput
{
return _list;
}
-
- protected function removeKeyDownEventListener():void {
- list.removeEventListener(KeyboardEvent.KEY_DOWN, keyDownEventHandler, true);
- }
-
public function set list(value:List):void
{
if(_list)
{
- removeKeyDownEventListener();
+ removeListListeners();
}
_list = value;
@@ -94,10 +89,19 @@ package org.apache.royale.jewel.beads.controls.textinput
keyBead.tearDown();
_list.removeBead(keyBead);
}
- list.addEventListener(KeyboardEvent.KEY_DOWN, keyDownEventHandler, true);
+
+ addListListeners();
}
}
+ protected function addListListeners():void {
+ list.addEventListener(KeyboardEvent.KEY_DOWN, keyDownEventHandler, true);
+ }
+
+ protected function removeListListeners():void {
+ list.removeEventListener(KeyboardEvent.KEY_DOWN, keyDownEventHandler, true);
+ }
+
/**
*
*