[GitHub] [iceberg] jackye1995 commented on pull request #2887: Core: allow creating v2 tables through table property

[GitBox <gi...@apache.org>]

jackye1995 commented on pull request #2887:
URL: https://github.com/apache/iceberg/pull/2887#issuecomment-888718478


   > If we are going to set the table version through a reserved property, then I think we should build the reserved property into TableMetadata so it is consistent across all catalogs.
   
   @rdblue thanks for the comment! I was thinking to only allow people to create table in this way and update property will not have any effect, that's why I did it in the table builder directly. But now I think about it I realize it will also be beneficial to use this syntax to migrate existing tables to v2:
   
   ```sql
   ALTER TABLE SET TBLPROPERTIES ('format-version'='2')
   ```
   
   So it does make sense to do it directly in `TableMetadata`. I have updated the code and also tested with Spark to verify it works, please let me know if there is any other concern.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org