Re: [PR] Improved concatenation way in PropertiesStorage.java [cloudstack]

["DaanHoogland (via GitHub)" <gi...@apache.org>]

DaanHoogland commented on code in PR #7486:
URL: https://github.com/apache/cloudstack/pull/7486#discussion_r1378565390


##########
agent/src/main/java/com/cloud/agent/dao/impl/PropertiesStorage.java:
##########
@@ -92,11 +92,11 @@ public synchronized boolean configure(String name, Map<String, Object> params) {
             file = new File(path);
             try {
                 if (!file.createNewFile()) {
-                    s_logger.error("Unable to create _file: " + file.getAbsolutePath());
+                    s_logger.error(String.format("Unable to create _file: %s", file.getAbsolutePath()));
                     return false;
                 }
             } catch (IOException e) {
-                s_logger.error("Unable to create _file: " + file.getAbsolutePath(), e);
+                s_logger.error(String.format("Unable to create _file: %s", file.getAbsolutePath()), e);

Review Comment:
   can you concur @nikam14 ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org