[GitHub] [spark] amaliujia commented on a diff in pull request #38915: [SPARK-41382][CONNECT][PYTHON] Implement `product` function

[GitBox <gi...@apache.org>]

amaliujia commented on code in PR #38915:
URL: https://github.com/apache/spark/pull/38915#discussion_r1039881972


##########
connector/connect/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -539,6 +539,15 @@ class SparkConnectPlanner(session: SparkSession) {
    * @return
    */
   private def transformScalarFunction(fun: proto.Expression.UnresolvedFunction): Expression = {
+    if (fun.getFunctionName == "product") {

Review Comment:
   My concern on such way is it looks too specialized. Not sure how many such case we will have, but at least can we pull this `if and if` to a validation function?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org