[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7372: move param check to sem_xx level

[GitBox <gi...@apache.org>]

pkarashchenko commented on code in PR #7372:
URL: https://github.com/apache/incubator-nuttx/pull/7372#discussion_r1018398697


##########
sched/semaphore/sem_clockwait.c:
##########
@@ -268,6 +260,16 @@ int sem_clockwait(FAR sem_t *sem, clockid_t clockid,
 {
   int ret;
 
+  /* Verify the input parameters and, in case of an error, set
+   * errno appropriately.
+   */
+
+  if (abstime == NULL || sem == NULL)

Review Comment:
   ```suggestion
     if (sem == NULL || abstime == NULL)
   ```
   just from common sense perspective



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org