You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by daserge <gi...@git.apache.org> on 2016/04/15 14:39:24 UTC
[GitHub] cordova-android pull request: CB-11036 'args.slice is not a functi...
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-android/pull/291
CB-11036 'args.slice is not a function' when building windows with ot…
…her platform
Avoid parseOpts side effects on options obj passed in as it's then passed to other platforms
[Jira issue](https://issues.apache.org/jira/browse/CB-11036)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-android CB-11036
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/291.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #291
----
commit 0a64958b7d5ad1097feb576f7a8d7ef02f6e275c
Author: daserge <v-...@microsoft.com>
Date: 2016-04-15T12:37:44Z
CB-11036 'args.slice is not a function' when building windows with other platform
Avoid parseOpts side effects on options obj passed in as it's then passed to other platforms
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-11036 'args.slice is not a functi...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/291#issuecomment-212126887
Should the cloning happen in `cordova-lib` instead - to ensure isolation?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-11036 'args.slice is not a functi...
Posted by daserge <gi...@git.apache.org>.
Github user daserge closed the pull request at:
https://github.com/apache/cordova-android/pull/291
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-11036 'args.slice is not a functi...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-android/pull/291#issuecomment-212554803
You are right, thanks.
Filed https://github.com/apache/cordova-lib/pull/430
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org