You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "yaooqinn (via GitHub)" <gi...@apache.org> on 2026/03/02 14:57:18 UTC
[PR] [SPARK-55770][UI] Replace custom .btn-spark with Bootstrap 5 button variant [spark]
yaooqinn opened a new pull request, #54573:
URL: https://github.com/apache/spark/pull/54573
### What changes were proposed in this pull request?
Replace the custom `.btn-spark` CSS class with Bootstrap 5's built-in `btn-outline-secondary` class.
### Why are the changes needed?
The custom `.btn-spark` class (lines 45-59 in webui.css) defines a legacy gradient background, box-shadow, and hover transition that duplicate what Bootstrap 5 provides natively. Replacing it with `btn-outline-secondary` simplifies the CSS and ensures consistent look with the rest of the BS5-upgraded UI.
Part of SPARK-55760 (Spark Web UI Modernization).
### Does this PR introduce _any_ user-facing change?
Yes — the "Go" buttons in paged tables and stage page now use Bootstrap 5's outline-secondary style instead of the custom gradient style. The visual difference is minimal.
### How was this patch tested?
- Verified no remaining references to `btn-spark` in the codebase
- Visual inspection of paged table "Go" buttons
### Was this patch authored or co-authored using generative AI tooling?
Yes, GitHub Copilot was used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55770][UI] Replace custom .btn-spark with Bootstrap 5 button variant [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #54573:
URL: https://github.com/apache/spark/pull/54573#issuecomment-3985004411
### Screenshot
**Go button with `btn-outline-secondary`:**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55770][UI] Replace custom .btn-spark with Bootstrap 5 button variant [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #54573:
URL: https://github.com/apache/spark/pull/54573#issuecomment-3988855542
filed SPARK-55810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55770][UI] Replace custom .btn-spark with Bootstrap 5 button variant [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn closed pull request #54573: [SPARK-55770][UI] Replace custom .btn-spark with Bootstrap 5 button variant
URL: https://github.com/apache/spark/pull/54573
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55770][UI] Replace custom .btn-spark with Bootstrap 5 button variant [spark]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #54573:
URL: https://github.com/apache/spark/pull/54573#issuecomment-3988674994
found a negative impact, not sure if caused by this PR
new vs. old
<img width="1483" height="515" alt="image" src="https://github.com/user-attachments/assets/90559fe4-9213-49f9-9289-fd4d712fbfb6" />
<img width="1495" height="286" alt="image" src="https://github.com/user-attachments/assets/e21832e2-5b3f-49d0-84a6-94e1c7ee1f3c" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55770][UI] Replace custom .btn-spark with Bootstrap 5 button variant [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #54573:
URL: https://github.com/apache/spark/pull/54573#issuecomment-3988716911
Hi, can you file a subtask for https://issues.apache.org/jira/browse/SPARK-55760. this could be caused by https://issues.apache.org/jira/browse/SPARK-55753, some details might change a bit via BS4->BS5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55770][UI] Replace custom .btn-spark with Bootstrap 5 button variant [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #54573:
URL: https://github.com/apache/spark/pull/54573#issuecomment-3985005093
### Screenshot
**Go button with `btn-outline-secondary`:**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55770][UI] Replace custom .btn-spark with Bootstrap 5 button variant [spark]
Posted by "yaooqinn (via GitHub)" <gi...@apache.org>.
yaooqinn commented on PR #54573:
URL: https://github.com/apache/spark/pull/54573#issuecomment-3988452564
Merged to master, thank you @dongjoon-hyun @holdenk @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org