You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/11/11 17:02:32 UTC
[GitHub] [solr] risdenk opened a new pull request, #1176: SOLR-16132: Stop gpg-agent after use
risdenk opened a new pull request, #1176:
URL: https://github.com/apache/solr/pull/1176
https://issues.apache.org/jira/browse/SOLR-16132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on a diff in pull request #1176: SOLR-16132: Stop gpg-agent after use
Posted by GitBox <gi...@apache.org>.
risdenk commented on code in PR #1176:
URL: https://github.com/apache/solr/pull/1176#discussion_r1020432520
##########
dev-tools/scripts/smokeTestRelease.py:
##########
@@ -324,6 +327,11 @@ def checkSigs(urlString, version, tmpDir, isSigned, keysFile):
if line.lower().find('warning') != -1:
print(' GPG: %s' % line.strip())
+ # Make sure to shutdown the GPG agent at the end
Review Comment:
I think line 323 above is missing `--homedir`...
##########
dev-tools/scripts/smokeTestRelease.py:
##########
@@ -277,16 +277,19 @@ def checkSigs(urlString, version, tmpDir, isSigned, keysFile):
if os.path.exists(gpgHomeDir):
shutil.rmtree(gpgHomeDir)
os.makedirs(gpgHomeDir, 0o700)
- run('gpg --homedir %s --import %s' % (gpgHomeDir, keysFile),
- '%s/solr.gpg.import.log' % tmpDir)
+ gpgLogFile = '%s/solr.gpg.import.log' % tmpDir
+ run('gpg --homedir %s --import %s' % (gpgHomeDir, keysFile), gpgLogFile)
Review Comment:
This GPG stuff would be nicer to move after testChanges? or maybe in `isSigned`? If we aren't checking `isSigned` do we care about this gpg import?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk merged pull request #1176: SOLR-16132: Stop gpg-agent after use
Posted by GitBox <gi...@apache.org>.
risdenk merged PR #1176:
URL: https://github.com/apache/solr/pull/1176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1176: SOLR-16132: Stop gpg-agent after use
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1176:
URL: https://github.com/apache/solr/pull/1176#issuecomment-1312046628
This works after the verifyMavenSigs as well now. No more left over gpg agent :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] risdenk commented on pull request #1176: SOLR-16132: Stop gpg-agent after use
Posted by GitBox <gi...@apache.org>.
risdenk commented on PR #1176:
URL: https://github.com/apache/solr/pull/1176#issuecomment-1311984145
Well this fixed the explicit gpg invocations.
It did NOT fix the Maven check it looks like:
```
...
verify maven artifact sigs
...
```
I saw the gpg agent get created and shutdown at the beginning. I need to see where Maven is calling this to fix it too:
```
risdenk 42369 0.0 0.0 408637808 2256 ?? S 12:38PM 0:00.00 scdaemon --multi-server --homedir /tmp/smoke_solr_9.1.0_aa4f3d98ab19c201e7f3c74cd14c99174148616d_3/solr.gpg
risdenk 42368 0.0 0.0 408657760 1472 ?? Ss 12:38PM 0:00.01 gpg-agent --homedir /tmp/smoke_solr_9.1.0_aa4f3d98ab19c201e7f3c74cd14c99174148616d_3/solr.gpg --use-standard-socket --daemon
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org