You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "dpgaspar (via GitHub)" <gi...@apache.org> on 2023/06/13 15:17:50 UTC
[GitHub] [superset] dpgaspar opened a new pull request, #24390: fix: FAB CSS on Superset
dpgaspar opened a new pull request, #24390:
URL: https://github.com/apache/superset/pull/24390
### SUMMARY
Fixes reported issue on FAB, select2, font-awesome versions were bumped and static css locations changed
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24390: fix: FAB CSS on Superset
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24390:
URL: https://github.com/apache/superset/pull/24390#issuecomment-1589542372
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24390?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24390](https://app.codecov.io/gh/apache/superset/pull/24390?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (f109e23) into [master](https://app.codecov.io/gh/apache/superset/commit/ca478bd5c464f6731311d6b6649457b72d67bbeb?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ca478bd) will **decrease** coverage by `10.98%`.
> The diff coverage is `n/a`.
> :exclamation: Current head f109e23 differs from pull request most recent head 6498c80. Consider uploading reports for the commit 6498c80 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24390 +/- ##
===========================================
- Coverage 68.99% 58.02% -10.98%
===========================================
Files 1903 1903
Lines 74196 74123 -73
Branches 8110 8110
===========================================
- Hits 51194 43011 -8183
- Misses 20890 29000 +8110
Partials 2112 2112
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.93% <ø> (-0.05%)` | :arrow_down: |
| python | `60.60% <ø> (-22.75%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `54.50% <ø> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/superset/pull/24390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [superset/security/manager.py](https://app.codecov.io/gh/apache/superset/pull/24390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==) | `61.31% <ø> (-32.53%)` | :arrow_down: |
| [superset/views/core.py](https://app.codecov.io/gh/apache/superset/pull/24390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `39.75% <ø> (-35.00%)` | :arrow_down: |
... and [300 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24390/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar merged pull request #24390: fix: FAB CSS on Superset
Posted by "dpgaspar (via GitHub)" <gi...@apache.org>.
dpgaspar merged PR #24390:
URL: https://github.com/apache/superset/pull/24390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org