You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ca...@apache.org on 2018/08/24 10:52:50 UTC
[royale-asjs] branch develop updated: Selectable & Hoverable in
Itemrenderers, so we can deactivate the selection feature
This is an automated email from the ASF dual-hosted git repository.
carlosrovira pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
The following commit(s) were added to refs/heads/develop by this push:
new 5322441 Selectable & Hoverable in Itemrenderers, so we can deactivate the selection feature
5322441 is described below
commit 5322441f4c86c5ba238c1becf17138d39b3c3564
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Fri Aug 24 12:52:41 2018 +0200
Selectable & Hoverable in Itemrenderers, so we can deactivate the selection feature
---
.../apache/royale/core/ISelectableItemRenderer.as | 30 ++++++++++++++
.../html/supportClasses/UIItemRendererBase.as | 46 ++++++++++++++++++++++
2 files changed, 76 insertions(+)
diff --git a/frameworks/projects/Core/src/main/royale/org/apache/royale/core/ISelectableItemRenderer.as b/frameworks/projects/Core/src/main/royale/org/apache/royale/core/ISelectableItemRenderer.as
index 1917095..321d75b 100644
--- a/frameworks/projects/Core/src/main/royale/org/apache/royale/core/ISelectableItemRenderer.as
+++ b/frameworks/projects/Core/src/main/royale/org/apache/royale/core/ISelectableItemRenderer.as
@@ -56,6 +56,21 @@ package org.apache.royale.core
function set index(value:int):void;
/**
+ * <code>true</code> if the item renderer is can be selected
+ * false otherwise. Use to configure a renderer to be non
+ * selectable.
+ *
+ * Defaults to true
+ *
+ * @langversion 3.0
+ * @playerversion Flash 10.2
+ * @playerversion AIR 2.6
+ * @productversion Royale 0.9.3
+ */
+ function get selectable():Boolean;
+ function set selectable(value:Boolean):void;
+
+ /**
* <code>true</code> if the item renderer is rendering
* an item that is selected.
*
@@ -68,6 +83,21 @@ package org.apache.royale.core
function set selected(value:Boolean):void;
/**
+ * <code>true</code> if the item renderer is can be hovered
+ * false otherwise. Use to configure a renderer to be non
+ * hoverable.
+ *
+ * Defaults to true
+ *
+ * @langversion 3.0
+ * @playerversion Flash 10.2
+ * @playerversion AIR 2.6
+ * @productversion Royale 0.9.3
+ */
+ function get hoverable():Boolean;
+ function set hoverable(value:Boolean):void;
+
+ /**
* <code>true</code> if the item renderer is rendering
* an item that is under the mouse pointer.
*
diff --git a/frameworks/projects/Core/src/main/royale/org/apache/royale/html/supportClasses/UIItemRendererBase.as b/frameworks/projects/Core/src/main/royale/org/apache/royale/html/supportClasses/UIItemRendererBase.as
index 291596a..acc779c 100644
--- a/frameworks/projects/Core/src/main/royale/org/apache/royale/html/supportClasses/UIItemRendererBase.as
+++ b/frameworks/projects/Core/src/main/royale/org/apache/royale/html/supportClasses/UIItemRendererBase.as
@@ -261,6 +261,29 @@ package org.apache.royale.html.supportClasses
updateRenderer();
}
+ private var _selectable:Boolean = true;
+ /**
+ * <code>true</code> if the item renderer is can be selected
+ * false otherwise. Use to configure a renderer to be non
+ * selectable.
+ *
+ * Defaults to true
+ *
+ * @langversion 3.0
+ * @playerversion Flash 10.2
+ * @playerversion AIR 2.6
+ * @productversion Royale 0.9.3
+ */
+ public function get selectable():Boolean
+ {
+ return _selectable;
+ }
+
+ public function set selectable(value:Boolean):void
+ {
+ _selectable = value;
+ }
+
private var _selected:Boolean;
/**
@@ -281,6 +304,29 @@ package org.apache.royale.html.supportClasses
updateRenderer();
}
+ private var _hoverable:Boolean = true;
+ /**
+ * <code>true</code> if the item renderer is can be hovered
+ * false otherwise. Use to configure a renderer to be non
+ * hoverable.
+ *
+ * Defaults to true
+ *
+ * @langversion 3.0
+ * @playerversion Flash 10.2
+ * @playerversion AIR 2.6
+ * @productversion Royale 0.9.3
+ */
+ public function get hoverable():Boolean
+ {
+ return _hoverable;
+ }
+
+ public function set hoverable(value:Boolean):void
+ {
+ _hoverable = value;
+ }
+
private var _down:Boolean;
/**
Re: [royale-asjs] branch develop updated: Selectable & Hoverable in
Itemrenderers, so we can deactivate the selection feature
Posted by Carlos Rovira <ca...@apache.org>.
Hi Alex,
ok, I can make this change but must be some days ago. I put in my todo
list. This days I'm totally overbooked.
thanks
El vie., 30 nov. 2018 a las 20:29, Alex Harui (<ah...@adobe.com.invalid>)
escribió:
> Hi Carlos,
>
> This doesn't seem PAYG to me. ISelectableItemRenderer extends
> IItemRenderer. IItemRenderer is for non-selectable renderers. If you need
> to have a renderer that can have its selectability enabled at runtime, that
> should be in an extension and not in the core.
>
> Thanks,
> -Alex
>
> On 8/24/18, 3:52 AM, "carlosrovira@apache.org" <ca...@apache.org>
> wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> carlosrovira pushed a commit to branch develop
> in repository
> https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=02%7C01%7Caharui%40adobe.com%7Cd6c27570878c4d1a5f4708d609afbd2b%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636707047730825120&sdata=hQsfAP7UgeT53Rho%2F94%2BHf5yWgHU536Z9Xqn7l%2F4r%2B8%3D&reserved=0
>
>
> The following commit(s) were added to refs/heads/develop by this push:
> new 5322441 Selectable & Hoverable in Itemrenderers, so we can
> deactivate the selection feature
> 5322441 is described below
>
> commit 5322441f4c86c5ba238c1becf17138d39b3c3564
> Author: Carlos Rovira <ca...@apache.org>
> AuthorDate: Fri Aug 24 12:52:41 2018 +0200
>
> Selectable & Hoverable in Itemrenderers, so we can deactivate the
> selection feature
> ---
> .../apache/royale/core/ISelectableItemRenderer.as | 30 ++++++++++++++
> .../html/supportClasses/UIItemRendererBase.as | 46
> ++++++++++++++++++++++
> 2 files changed, 76 insertions(+)
>
> diff --git
> a/frameworks/projects/Core/src/main/royale/org/apache/royale/core/ISelectableItemRenderer.as
> b/frameworks/projects/Core/src/main/royale/org/apache/royale/core/ISelectableItemRenderer.as
> index 1917095..321d75b 100644
> ---
> a/frameworks/projects/Core/src/main/royale/org/apache/royale/core/ISelectableItemRenderer.as
> +++
> b/frameworks/projects/Core/src/main/royale/org/apache/royale/core/ISelectableItemRenderer.as
> @@ -56,6 +56,21 @@ package org.apache.royale.core
> function set index(value:int):void;
>
> /**
> + * <code>true</code> if the item renderer is can be selected
> + * false otherwise. Use to configure a renderer to be non
> + * selectable.
> + *
> + * Defaults to true
> + *
> + * @langversion 3.0
> + * @playerversion Flash 10.2
> + * @playerversion AIR 2.6
> + * @productversion Royale 0.9.3
> + */
> + function get selectable():Boolean;
> + function set selectable(value:Boolean):void;
> +
> + /**
> * <code>true</code> if the item renderer is rendering
> * an item that is selected.
> *
> @@ -68,6 +83,21 @@ package org.apache.royale.core
> function set selected(value:Boolean):void;
>
> /**
> + * <code>true</code> if the item renderer is can be hovered
> + * false otherwise. Use to configure a renderer to be non
> + * hoverable.
> + *
> + * Defaults to true
> + *
> + * @langversion 3.0
> + * @playerversion Flash 10.2
> + * @playerversion AIR 2.6
> + * @productversion Royale 0.9.3
> + */
> + function get hoverable():Boolean;
> + function set hoverable(value:Boolean):void;
> +
> + /**
> * <code>true</code> if the item renderer is rendering
> * an item that is under the mouse pointer.
> *
> diff --git
> a/frameworks/projects/Core/src/main/royale/org/apache/royale/html/supportClasses/UIItemRendererBase.as
> b/frameworks/projects/Core/src/main/royale/org/apache/royale/html/supportClasses/UIItemRendererBase.as
> index 291596a..acc779c 100644
> ---
> a/frameworks/projects/Core/src/main/royale/org/apache/royale/html/supportClasses/UIItemRendererBase.as
> +++
> b/frameworks/projects/Core/src/main/royale/org/apache/royale/html/supportClasses/UIItemRendererBase.as
> @@ -261,6 +261,29 @@ package org.apache.royale.html.supportClasses
> updateRenderer();
> }
>
> + private var _selectable:Boolean = true;
> + /**
> + * <code>true</code> if the item renderer is can be selected
> + * false otherwise. Use to configure a renderer to be non
> + * selectable.
> + *
> + * Defaults to true
> + *
> + * @langversion 3.0
> + * @playerversion Flash 10.2
> + * @playerversion AIR 2.6
> + * @productversion Royale 0.9.3
> + */
> + public function get selectable():Boolean
> + {
> + return _selectable;
> + }
> +
> + public function set selectable(value:Boolean):void
> + {
> + _selectable = value;
> + }
> +
> private var _selected:Boolean;
>
> /**
> @@ -281,6 +304,29 @@ package org.apache.royale.html.supportClasses
> updateRenderer();
> }
>
> + private var _hoverable:Boolean = true;
> + /**
> + * <code>true</code> if the item renderer is can be hovered
> + * false otherwise. Use to configure a renderer to be non
> + * hoverable.
> + *
> + * Defaults to true
> + *
> + * @langversion 3.0
> + * @playerversion Flash 10.2
> + * @playerversion AIR 2.6
> + * @productversion Royale 0.9.3
> + */
> + public function get hoverable():Boolean
> + {
> + return _hoverable;
> + }
> +
> + public function set hoverable(value:Boolean):void
> + {
> + _hoverable = value;
> + }
> +
> private var _down:Boolean;
>
> /**
>
>
>
>
--
Carlos Rovira
http://about.me/carlosrovira
Re: [royale-asjs] branch develop updated: Selectable & Hoverable in
Itemrenderers, so we can deactivate the selection feature
Posted by Alex Harui <ah...@adobe.com.INVALID>.
Hi Carlos,
This doesn't seem PAYG to me. ISelectableItemRenderer extends IItemRenderer. IItemRenderer is for non-selectable renderers. If you need to have a renderer that can have its selectability enabled at runtime, that should be in an extension and not in the core.
Thanks,
-Alex
On 8/24/18, 3:52 AM, "carlosrovira@apache.org" <ca...@apache.org> wrote:
This is an automated email from the ASF dual-hosted git repository.
carlosrovira pushed a commit to branch develop
in repository https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=02%7C01%7Caharui%40adobe.com%7Cd6c27570878c4d1a5f4708d609afbd2b%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636707047730825120&sdata=hQsfAP7UgeT53Rho%2F94%2BHf5yWgHU536Z9Xqn7l%2F4r%2B8%3D&reserved=0
The following commit(s) were added to refs/heads/develop by this push:
new 5322441 Selectable & Hoverable in Itemrenderers, so we can deactivate the selection feature
5322441 is described below
commit 5322441f4c86c5ba238c1becf17138d39b3c3564
Author: Carlos Rovira <ca...@apache.org>
AuthorDate: Fri Aug 24 12:52:41 2018 +0200
Selectable & Hoverable in Itemrenderers, so we can deactivate the selection feature
---
.../apache/royale/core/ISelectableItemRenderer.as | 30 ++++++++++++++
.../html/supportClasses/UIItemRendererBase.as | 46 ++++++++++++++++++++++
2 files changed, 76 insertions(+)
diff --git a/frameworks/projects/Core/src/main/royale/org/apache/royale/core/ISelectableItemRenderer.as b/frameworks/projects/Core/src/main/royale/org/apache/royale/core/ISelectableItemRenderer.as
index 1917095..321d75b 100644
--- a/frameworks/projects/Core/src/main/royale/org/apache/royale/core/ISelectableItemRenderer.as
+++ b/frameworks/projects/Core/src/main/royale/org/apache/royale/core/ISelectableItemRenderer.as
@@ -56,6 +56,21 @@ package org.apache.royale.core
function set index(value:int):void;
/**
+ * <code>true</code> if the item renderer is can be selected
+ * false otherwise. Use to configure a renderer to be non
+ * selectable.
+ *
+ * Defaults to true
+ *
+ * @langversion 3.0
+ * @playerversion Flash 10.2
+ * @playerversion AIR 2.6
+ * @productversion Royale 0.9.3
+ */
+ function get selectable():Boolean;
+ function set selectable(value:Boolean):void;
+
+ /**
* <code>true</code> if the item renderer is rendering
* an item that is selected.
*
@@ -68,6 +83,21 @@ package org.apache.royale.core
function set selected(value:Boolean):void;
/**
+ * <code>true</code> if the item renderer is can be hovered
+ * false otherwise. Use to configure a renderer to be non
+ * hoverable.
+ *
+ * Defaults to true
+ *
+ * @langversion 3.0
+ * @playerversion Flash 10.2
+ * @playerversion AIR 2.6
+ * @productversion Royale 0.9.3
+ */
+ function get hoverable():Boolean;
+ function set hoverable(value:Boolean):void;
+
+ /**
* <code>true</code> if the item renderer is rendering
* an item that is under the mouse pointer.
*
diff --git a/frameworks/projects/Core/src/main/royale/org/apache/royale/html/supportClasses/UIItemRendererBase.as b/frameworks/projects/Core/src/main/royale/org/apache/royale/html/supportClasses/UIItemRendererBase.as
index 291596a..acc779c 100644
--- a/frameworks/projects/Core/src/main/royale/org/apache/royale/html/supportClasses/UIItemRendererBase.as
+++ b/frameworks/projects/Core/src/main/royale/org/apache/royale/html/supportClasses/UIItemRendererBase.as
@@ -261,6 +261,29 @@ package org.apache.royale.html.supportClasses
updateRenderer();
}
+ private var _selectable:Boolean = true;
+ /**
+ * <code>true</code> if the item renderer is can be selected
+ * false otherwise. Use to configure a renderer to be non
+ * selectable.
+ *
+ * Defaults to true
+ *
+ * @langversion 3.0
+ * @playerversion Flash 10.2
+ * @playerversion AIR 2.6
+ * @productversion Royale 0.9.3
+ */
+ public function get selectable():Boolean
+ {
+ return _selectable;
+ }
+
+ public function set selectable(value:Boolean):void
+ {
+ _selectable = value;
+ }
+
private var _selected:Boolean;
/**
@@ -281,6 +304,29 @@ package org.apache.royale.html.supportClasses
updateRenderer();
}
+ private var _hoverable:Boolean = true;
+ /**
+ * <code>true</code> if the item renderer is can be hovered
+ * false otherwise. Use to configure a renderer to be non
+ * hoverable.
+ *
+ * Defaults to true
+ *
+ * @langversion 3.0
+ * @playerversion Flash 10.2
+ * @playerversion AIR 2.6
+ * @productversion Royale 0.9.3
+ */
+ public function get hoverable():Boolean
+ {
+ return _hoverable;
+ }
+
+ public function set hoverable(value:Boolean):void
+ {
+ _hoverable = value;
+ }
+
private var _down:Boolean;
/**