You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Lars Volker (Code Review)" <ge...@cloudera.org> on 2017/03/01 22:46:04 UTC
[native-toolchain-CR] Bump breakpad upstream version
Lars Volker has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6213
Change subject: Bump breakpad upstream version
......................................................................
Bump breakpad upstream version
This will give us better support for DWARF version 4,
support for redaction of sensitive data, and a multitude of bug fixes.
Our previous version has been from June 12th 2015, this change bumps it
to Feb 28th 2017.
It also includes a script from Kudu that can be used to create tarballs
from the Breakpad Git repository. Breakpad itself does not do releases.
Change-Id: I8859ced5048a9f3098c9ec3f24e73311111700a1
---
M buildall.sh
A source/breakpad/make-breakpad-src-archive.sh
2 files changed, 62 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/13/6213/1
--
To view, visit http://gerrit.cloudera.org:8080/6213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8859ced5048a9f3098c9ec3f24e73311111700a1
Gerrit-PatchSet: 1
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
[native-toolchain-CR] Bump breakpad upstream version
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: Bump breakpad upstream version
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6213/2//COMMIT_MSG
Commit Message:
PS2, Line 7: upstream
remove, not sure where 'upstream' is in this context.
http://gerrit.cloudera.org:8080/#/c/6213/2/source/breakpad/make-breakpad-src-archive.sh
File source/breakpad/make-breakpad-src-archive.sh:
Line 21: # releases.
Mention where the original is?
--
To view, visit http://gerrit.cloudera.org:8080/6213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8859ced5048a9f3098c9ec3f24e73311111700a1
Gerrit-PatchSet: 2
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: Yes
[native-toolchain-CR] Bump breakpad version
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has submitted this change and it was merged.
Change subject: Bump breakpad version
......................................................................
Bump breakpad version
This will give us better support for DWARF version 4,
support for redaction of sensitive data, and a multitude of bug fixes.
Our previous version has been from June 12th 2015, this change bumps it
to Feb 28th 2017.
It also includes a script from Kudu that can be used to create tarballs
from the Breakpad Git repository. Breakpad itself does not do releases.
Change-Id: I8859ced5048a9f3098c9ec3f24e73311111700a1
---
M buildall.sh
A source/breakpad/make-breakpad-src-archive.sh
2 files changed, 63 insertions(+), 1 deletion(-)
Approvals:
Lars Volker: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/6213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8859ced5048a9f3098c9ec3f24e73311111700a1
Gerrit-PatchSet: 3
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
[native-toolchain-CR] Bump breakpad version
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.
Change subject: Bump breakpad version
......................................................................
Patch Set 3: Code-Review+2 Verified+1
(2 comments)
Thank you for the review. I addressed all your comments and ran a full build.
http://gerrit.cloudera.org:8080/#/c/6213/2//COMMIT_MSG
Commit Message:
PS2, Line 7: version
> remove, not sure where 'upstream' is in this context.
Done
http://gerrit.cloudera.org:8080/#/c/6213/2/source/breakpad/make-breakpad-src-archive.sh
File source/breakpad/make-breakpad-src-archive.sh:
Line 21: # releases. This script was taken from the Apache Kudu project at
> Mention where the original is?
Done
--
To view, visit http://gerrit.cloudera.org:8080/6213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8859ced5048a9f3098c9ec3f24e73311111700a1
Gerrit-PatchSet: 3
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: Yes
[native-toolchain-CR] Bump breakpad version
Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Hello Henry Robinson,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6213
to look at the new patch set (#3).
Change subject: Bump breakpad version
......................................................................
Bump breakpad version
This will give us better support for DWARF version 4,
support for redaction of sensitive data, and a multitude of bug fixes.
Our previous version has been from June 12th 2015, this change bumps it
to Feb 28th 2017.
It also includes a script from Kudu that can be used to create tarballs
from the Breakpad Git repository. Breakpad itself does not do releases.
Change-Id: I8859ced5048a9f3098c9ec3f24e73311111700a1
---
M buildall.sh
A source/breakpad/make-breakpad-src-archive.sh
2 files changed, 63 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/native-toolchain refs/changes/13/6213/3
--
To view, visit http://gerrit.cloudera.org:8080/6213
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8859ced5048a9f3098c9ec3f24e73311111700a1
Gerrit-PatchSet: 3
Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-Owner: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>