You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/06/29 00:16:37 UTC

[GitHub] [beam] ibzib commented on a change in pull request #15089: [BEAM-12533] Add simple `__repr__` for `DeferredDataFrame` and `DeferredSeries`

ibzib commented on a change in pull request #15089:
URL: https://github.com/apache/beam/pull/15089#discussion_r660189622



##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -143,6 +143,14 @@ def wrapper(self, *args, **kwargs):
 
 
 class DeferredDataFrameOrSeries(frame_base.DeferredFrame):
+  def _render_indexes(self):

Review comment:
       It may be better to keep things simple here and do `indexes={...}` even for a single index. Though TBH I am not sure why `index.name` and `index.names` are separate attributes (is this different between a pandas index and a deferred index)?
   
   Related question, why can't we use `repr(index)`? I wonder if there is more to an index than just its name? For example, if there are different types of index (which I gather there are) could that information be useful to the user?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org