[GitHub] [incubator-superset] michael-s-molina commented on a change in pull request #12213: fix: tests errors and warnings - iteration 1 (#12212)

[GitBox <gi...@apache.org>]

michael-s-molina commented on a change in pull request #12213:
URL: https://github.com/apache/incubator-superset/pull/12213#discussion_r552059329



##########
File path: superset-frontend/src/components/Menu/SubMenu.tsx
##########
@@ -138,41 +138,44 @@ const SubMenu: React.FunctionComponent<SubMenuProps> = props => {
             props.tabs.map(tab => {
               if ((props.usesRouter || hasHistory) && !!tab.usesRouter) {
                 return (
-                  <li
-                    className={tab.name === props.activeChild ? 'active' : ''}
-                    key={`${tab.label}`}
-                  >
-                    <div>
-                      <Link to={tab.url || ''}>{tab.label}</Link>
-                    </div>
-                  </li>
+                  <React.Fragment key={`${tab.label}`}>

Review comment:
       @ktmud Yes this fix the `activeHref` warning. I totally agree that we should migrate. This is already in my TODO list 😉. This will fix the warning until then.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org