You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by cwestin <gi...@git.apache.org> on 2015/10/13 23:56:29 UTC

[GitHub] drill pull request: DRILL-3930: Remove direct references to TopLev...

GitHub user cwestin opened a pull request:

    https://github.com/apache/drill/pull/200

    DRILL-3930: Remove direct references to TopLevelAllocator from unit t…

    …ests
    
    Ensure RootAllocatorFactory is used throughout the code so
    that we can change allocators via configuration or software. Use
    DrillAutoCloseables to handle exceptions that could happen from some
    allocator close() calls when the allocator is in an improper state.
    
    Unit tests pass
    Regression suite passes, except for
    - a couple of the known "Selected column 'dir0' must have name 'columns' or must be plain '*'"

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cwestin/incubator-drill DRILL-3930

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/drill/pull/200.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #200
    
----
commit 5f390ad35eec9147bfaca1763b94f2cbf1d55821
Author: Chris Westin <cw...@yahoo.com>
Date:   2015-10-13T20:49:57Z

    DRILL-3930: Remove direct references to TopLevelAllocator from unit tests
    Ensure RootAllocatorFactory is used throughout the code so
    that we can change allocators via configuration or software. Use
    DrillAutoCloseables to handle exceptions that could happen from some
    allocator close() calls when the allocator is in an improper state.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request: DRILL-3930: Remove direct references to TopLev...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/drill/pull/200


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] drill pull request: DRILL-3930: Remove direct references to TopLev...

Posted by hnfgns <gi...@git.apache.org>.

Github user hnfgns commented on the pull request:

    https://github.com/apache/drill/pull/200#issuecomment-148187351
  
    +1 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---