You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Alenka Frim (Jira)" <ji...@apache.org> on 2021/07/17 12:39:00 UTC

[jira] [Commented] (ARROW-13094) [R] Bindings for sign()

    [ https://issues.apache.org/jira/browse/ARROW-13094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382551#comment-17382551 ] 

Alenka Frim commented on ARROW-13094:
-------------------------------------

[~npr] this is a duplicate of https://issues.apache.org/jira/browse/ARROW-13357.

> [R] Bindings for sign()
> -----------------------
>
>                 Key: ARROW-13094
>                 URL: https://issues.apache.org/jira/browse/ARROW-13094
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: R
>            Reporter: Ian Cook
>            Assignee: Alenka Frim
>            Priority: Major
>             Fix For: 6.0.0
>
>
> ARROW-12861 adds a {{sign}} kernel to the C++ library. Add a mapping to this in the R package.
> I think this should be as simple as just adding
> {code:java}
> "sign" = "sign",{code}
> to {{.unary_function_map}} in {{expression.R}}, plus a simple test.
> Note that the C++ library's {{sign}} kernel returns integer output whereas base R's {{sign}} function returns numeric (double) output, so a test written with {{expect_dplyr_equal()}} might fail unless it explicitly converts the output from {{sign()}} using {{as.numeric()}} or {{as.integer()}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)