You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "yuxiqian (via GitHub)" <gi...@apache.org> on 2024/05/29 11:40:31 UTC

[PR] [FLINK-15753][web] Displaying non-numeric metrics in Web UI dashboard [flink]

yuxiqian opened a new pull request, #24867:
URL: https://github.com/apache/flink/pull/24867

   ## What is the purpose of the change
   
   Currently, Flink allows creating gauge metrics with various types [[1]](https://nightlies.apache.org/flink/flink-docs-master/docs/ops/metrics/#gauge). However Web UI doesn't support showing any types other than numerics and always displays `NaN`, which isn't very helpful. This change lets dashboard displays raw metric value when converting to numbers isn't applicable.
   
   ## Brief change log
   
     - Adds raw value display as fallback when receiving non-numeric metric values
     - Changes "Chart / Numeric" label to "Chart / Literal" because not all metrics are of number type
   
   ## Verifying this change
   
   This change is a trivial work without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-15753][web] Displaying non-numeric metrics in Web UI dashboard [flink]

Posted by "yuxiqian (via GitHub)" <gi...@apache.org>.
yuxiqian commented on PR #24867:
URL: https://github.com/apache/flink/pull/24867#issuecomment-2138565763

   Ah I see. Thanks for your clarification!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-15753][web] Displaying non-numeric metrics in Web UI dashboard [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #24867:
URL: https://github.com/apache/flink/pull/24867#issuecomment-2137215585

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a91eedf8891c31ea59064821ff124ca6c473da6d",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a91eedf8891c31ea59064821ff124ca6c473da6d",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a91eedf8891c31ea59064821ff124ca6c473da6d UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-15753][web] Displaying non-numeric metrics in Web UI dashboard [flink]

Posted by "X-czh (via GitHub)" <gi...@apache.org>.
X-czh commented on PR #24867:
URL: https://github.com/apache/flink/pull/24867#issuecomment-2138542042

   AFAIK, it is planned to remove the support for non-numeric gauge metric values in Flink 2.0, see [FLINK-6053](https://issues.apache.org/jira/browse/FLINK-6053).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [FLINK-15753][web] Displaying non-numeric metrics in Web UI dashboard [flink]

Posted by "yuxiqian (via GitHub)" <gi...@apache.org>.
yuxiqian closed pull request #24867: [FLINK-15753][web] Displaying non-numeric metrics in Web UI dashboard
URL: https://github.com/apache/flink/pull/24867


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org