You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Ruediger Pluem <rp...@apache.org> on 2018/08/31 12:50:13 UTC
Re: svn commit: r1837590 - in /httpd/httpd/trunk: CHANGES
include/ap_mmn.h include/scoreboard.h modules/generators/mod_status.c
server/scoreboard.c
On 08/07/2018 12:48 PM, rjung@apache.org wrote:
> Author: rjung
> Date: Tue Aug 7 10:48:05 2018
> New Revision: 1837590
>
> URL: http://svn.apache.org/viewvc?rev=1837590&view=rev
> Log:
> mod_status: Add cumulated response duration time
> in milliseconds.
>
> Modified:
> httpd/httpd/trunk/CHANGES
> httpd/httpd/trunk/include/ap_mmn.h
> httpd/httpd/trunk/include/scoreboard.h
> httpd/httpd/trunk/modules/generators/mod_status.c
> httpd/httpd/trunk/server/scoreboard.c
>
view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/generators/mod_status.c (original)
> +++ httpd/httpd/trunk/modules/generators/mod_status.c Tue Aug 7 10:48:05 2018
> @@ -461,8 +465,9 @@ static int status_handler(request_rec *r
> if (ap_extended_status) {
> if (short_report) {
> ap_rprintf(r, "Total Accesses: %lu\nTotal kBytes: %"
> - APR_OFF_T_FMT "\n",
> - count, kbcount);
> + APR_OFF_T_FMT "\nTotal Duration: %"
> + APR_TIME_T_FMT "\n",
> + count, kbcount, duration_global / 1000);
Is it a good idea to use the literal 1000 here or shouldn't we better use the respective APR macros for converting from
microseconds?
Regards
Rüdiger
Re: svn commit: r1837590 - in /httpd/httpd/trunk: CHANGES
include/ap_mmn.h include/scoreboard.h modules/generators/mod_status.c
server/scoreboard.c
Posted by Rainer Jung <ra...@kippdata.de>.
Am 31.08.2018 um 14:50 schrieb Ruediger Pluem:
>
>
> On 08/07/2018 12:48 PM, rjung@apache.org wrote:
>> Author: rjung
>> Date: Tue Aug 7 10:48:05 2018
>> New Revision: 1837590
>>
>> URL: http://svn.apache.org/viewvc?rev=1837590&view=rev
>> Log:
>> mod_status: Add cumulated response duration time
>> in milliseconds.
>>
>> Modified:
>> httpd/httpd/trunk/CHANGES
>> httpd/httpd/trunk/include/ap_mmn.h
>> httpd/httpd/trunk/include/scoreboard.h
>> httpd/httpd/trunk/modules/generators/mod_status.c
>> httpd/httpd/trunk/server/scoreboard.c
>>
> view=diff
>> ==============================================================================
>> --- httpd/httpd/trunk/modules/generators/mod_status.c (original)
>> +++ httpd/httpd/trunk/modules/generators/mod_status.c Tue Aug 7 10:48:05 2018
>
>> @@ -461,8 +465,9 @@ static int status_handler(request_rec *r
>> if (ap_extended_status) {
>> if (short_report) {
>> ap_rprintf(r, "Total Accesses: %lu\nTotal kBytes: %"
>> - APR_OFF_T_FMT "\n",
>> - count, kbcount);
>> + APR_OFF_T_FMT "\nTotal Duration: %"
>> + APR_TIME_T_FMT "\n",
>> + count, kbcount, duration_global / 1000);
>
> Is it a good idea to use the literal 1000 here or shouldn't we better use the respective APR macros for converting from
> microseconds?
Good point, will do, thanks for the review.
Rainer