You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/01/16 01:54:25 UTC
Review Request 42374: Logger Module: Add test filter for tests
requiring `logrotate`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42374/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Artem Harutyunyan.
Bugs: MESOS-4136
https://issues.apache.org/jira/browse/MESOS-4136
Repository: mesos
Description
-------
The `logrotate` binary is used by the non-default `RotatingContainerLogger` module. On some systems, `logrotate` is not provided by default.
Diffs
-----
src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787
Diff: https://reviews.apache.org/r/42374/diff/
Testing
-------
See later reviews.
Thanks,
Joseph Wu
Re: Review Request 42374: Logger Module: Add test filter for tests
requiring `logrotate`.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42374/#review115840
-----------------------------------------------------------
Ship it!
Ship It!
- Bernd Mathiske
On Jan. 19, 2016, 7:41 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42374/
> -----------------------------------------------------------
>
> (Updated Jan. 19, 2016, 7:41 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Artem Harutyunyan.
>
>
> Bugs: MESOS-4136
> https://issues.apache.org/jira/browse/MESOS-4136
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `logrotate` binary is used by the non-default `RotatingContainerLogger` module. On some systems, `logrotate` is not provided by default.
>
>
> Diffs
> -----
>
> src/tests/environment.cpp a6322f260c23796ceaa5d2080126ea9fef0b5ac6
>
> Diff: https://reviews.apache.org/r/42374/diff/
>
>
> Testing
> -------
>
> See later reviews.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 42374: Logger Module: Add test filter for tests
requiring `logrotate`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42374/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 7:41 p.m.)
Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Artem Harutyunyan.
Changes
-------
Changed capitalization of logrotate.
Bugs: MESOS-4136
https://issues.apache.org/jira/browse/MESOS-4136
Repository: mesos
Description
-------
The `logrotate` binary is used by the non-default `RotatingContainerLogger` module. On some systems, `logrotate` is not provided by default.
Diffs (updated)
-----
src/tests/environment.cpp a6322f260c23796ceaa5d2080126ea9fef0b5ac6
Diff: https://reviews.apache.org/r/42374/diff/
Testing
-------
See later reviews.
Thanks,
Joseph Wu
Re: Review Request 42374: Logger Module: Add test filter for tests
requiring `logrotate`.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42374/
-----------------------------------------------------------
(Updated Jan. 19, 2016, 12:22 p.m.)
Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Artem Harutyunyan.
Changes
-------
The test filters were alphabetized (yay!). Rebased.
Bugs: MESOS-4136
https://issues.apache.org/jira/browse/MESOS-4136
Repository: mesos
Description
-------
The `logrotate` binary is used by the non-default `RotatingContainerLogger` module. On some systems, `logrotate` is not provided by default.
Diffs (updated)
-----
src/tests/environment.cpp a6322f260c23796ceaa5d2080126ea9fef0b5ac6
Diff: https://reviews.apache.org/r/42374/diff/
Testing
-------
See later reviews.
Thanks,
Joseph Wu
Re: Review Request 42374: Logger Module: Add test filter for tests
requiring `logrotate`.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42374/#review115100
-----------------------------------------------------------
Ship it!
src/tests/environment.cpp (line 365)
<https://reviews.apache.org/r/42374/#comment175964>
We should really add our own `os::which` so that we can easily differentiate the error cases here. In particular, what if just `os::system` fails? or `which` fails but `logrotate` is still accesible on the path? Having something like a `os::which` which returns a `Result`, either some (it exists on the path), none (it doesn't exist on the path), or `Error` (there was an error determining that information) would be great. While an `Error` or none would still do the same thing here, it would probably give a better error message.
Feel free to add these kinds of primitives on the journey in the future!
- Benjamin Hindman
On Jan. 16, 2016, 12:54 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42374/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2016, 12:54 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Artem Harutyunyan.
>
>
> Bugs: MESOS-4136
> https://issues.apache.org/jira/browse/MESOS-4136
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The `logrotate` binary is used by the non-default `RotatingContainerLogger` module. On some systems, `logrotate` is not provided by default.
>
>
> Diffs
> -----
>
> src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787
>
> Diff: https://reviews.apache.org/r/42374/diff/
>
>
> Testing
> -------
>
> See later reviews.
>
>
> Thanks,
>
> Joseph Wu
>
>