You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by bu...@apache.org on 2005/03/22 09:43:03 UTC
DO NOT REPLY [Bug 16280] -
Error Message always logged to log4j when calling close() on TelnetAppender
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG�
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://issues.apache.org/bugzilla/show_bug.cgi?id=16280>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND�
INSERTED IN THE BUG DATABASE.
http://issues.apache.org/bugzilla/show_bug.cgi?id=16280
------- Additional Comments From brownf@mail.co.stanislaus.ca.us 2005-03-22 09:43 -------
(In reply to comment #2)
> Can you please attached your patch in diff -u format, assuming it's still
> applicable and you still care? Thanks.
Maybe I can help. I downloaded revision 1.17 of TelnetAppender and compared it
to Matt's revision (which was probably derived from a much earlier revision).
Apart from many minor and/or unrelated differences throughout, it came down to
some significant differences in send() and finalize(). Matt said his changes
were all in finalize(), so the changes in send() are probably due to some other
revision(s).
What that leaves you with is...
1. the following code to be inserted at the very beginning of finalize():
done = true; //break out of while loop as soon as last accept() is received.
try {
//Sends final client socket to initiate close
Socket lastSocket = new Socket("localhost", getPort());
lastSocket.close();
} catch(Exception exception){
}
2. removing (or not) this single stmt at the end of finalize():
done = true;
I know this isn't a diff file, but maybe it'll suffice :)
--
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org