[GitHub] [shardingsphere] strongduanmu commented on a change in pull request #11633: shardingsphere-jdbc-core yml config add schemaName

[GitBox <gi...@apache.org>]

strongduanmu commented on a change in pull request #11633:
URL: https://github.com/apache/shardingsphere/pull/11633#discussion_r682365937



##########
File path: shardingsphere-scaling/shardingsphere-scaling-core/src/main/java/org/apache/shardingsphere/scaling/core/config/datasource/ShardingSphereJDBCDataSourceConfiguration.java
##########
@@ -73,6 +74,7 @@ public ScalingDataSourceConfigurationWrap wrap() {
     @Override
     public DataSource toDataSource() throws SQLException {
         return ShardingSphereDataSourceFactory.createDataSource(new YamlDataSourceConfigurationSwapper().swapToDataSources(
-                rootRuleConfigs.getDataSources()), Collections.singletonList(ShardingRuleConfigurationSwapper.findAndConvertShardingRuleConfiguration(rootRuleConfigs.getRules())), null);
+                rootRuleConfigs.getDataSources()), Collections.singletonList(ShardingRuleConfigurationSwapper.findAndConvertShardingRuleConfiguration(rootRuleConfigs.getRules())),

Review comment:
       @zjcnb Does this place need to be marked as TODO?

##########
File path: shardingsphere-jdbc/shardingsphere-jdbc-core/src/main/java/org/apache/shardingsphere/driver/api/ShardingSphereDataSourceFactory.java
##########
@@ -55,12 +69,14 @@ public static DataSource createDataSource(final Map<String, DataSource> dataSour
      * @param dataSource data source
      * @param configurations rule configurations
      * @param props properties for data source
+     * @param schemaName for configurations

Review comment:
       @zjcnb `* @param schemaName schema name for configurations` is better?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org