You are viewing a plain text version of this content. The canonical link for it is here.
Posted to soap-dev@ws.apache.org by Pavel Ausianik <Pa...@epam.com> on 2002/11/11 18:53:49 UTC
[PATCH] Use static predefined ContentType
Hello,
I have prepared patch for using predefined const ContentType, similar to
patch was done to MimeType . I have traced MimeBodyPart.isMimeType
implementation...
Please find attached
Best regards,
Pavel
Re: [PATCH] Use static predefined ContentType
Posted by Scott Nichol <sn...@scottnichol.com>.
Pavel,
I will be committing changes I made to HTTPUtils, TransportMessage and
SOAPHTTPConnection later today, after which I will apply and commit your
changes.
Also, I have come to the conclusion that, as you suggested, we should
add a getEnvelope method to SOAPTransport, not SOAPContext. For
SOAPHTTPConnection, it will just delegate to
TransportMessage#getEnvelope. When you were looking into this, did you
determine how FilterTransport should implement this method?
Scott Nichol
Perftest results on my AMD K6-III rig
Scenario Run 1 Run 2
Code from 11/10 180.299 171.937
+ my changes 177.305 165.798
+ getEnvelope 167.611 157.727
So, the getEnvelope short-cut makes a big difference (I coded Call to
use getEnvelope for SOAPTransport instanceof SOAPHTTPConnection so I
could run the test). My changes have more benefit for larger messages,
as they prevent one copy of the full message content, but also copies of
subsets of larger messages as done by the ByteArrayOutputStream that
underlies ByteArrayDataSource.
----- Original Message -----
From: "Pavel Ausianik" <Pa...@epam.com>
To: <so...@xml.apache.org>
Sent: Monday, November 11, 2002 12:53 PM
Subject: [PATCH] Use static predefined ContentType
> Hello,
>
> I have prepared patch for using predefined const ContentType,
similar to
> patch was done to MimeType . I have traced MimeBodyPart.isMimeType
> implementation...
>
> Please find attached
>
> Best regards,
> Pavel
>
>
------------------------------------------------------------------------
--------
> --
> To unsubscribe, e-mail: <ma...@xml.apache.org>
> For additional commands, e-mail: <ma...@xml.apache.org>
Re: [PATCH] Use static predefined ContentType
Posted by Scott Nichol <sn...@scottnichol.com>.
Pavel,
I will be committing changes I made to HTTPUtils, TransportMessage and
SOAPHTTPConnection later today, after which I will apply and commit your
changes.
Also, I have come to the conclusion that, as you suggested, we should
add a getEnvelope method to SOAPTransport, not SOAPContext. For
SOAPHTTPConnection, it will just delegate to
TransportMessage#getEnvelope. When you were looking into this, did you
determine how FilterTransport should implement this method?
Scott Nichol
Perftest results on my AMD K6-III rig
Scenario Run 1 Run 2
Code from 11/10 180.299 171.937
+ my changes 177.305 165.798
+ getEnvelope 167.611 157.727
So, the getEnvelope short-cut makes a big difference (I coded Call to
use getEnvelope for SOAPTransport instanceof SOAPHTTPConnection so I
could run the test). My changes have more benefit for larger messages,
as they prevent one copy of the full message content, but also copies of
subsets of larger messages as done by the ByteArrayOutputStream that
underlies ByteArrayDataSource.
----- Original Message -----
From: "Pavel Ausianik" <Pa...@epam.com>
To: <so...@xml.apache.org>
Sent: Monday, November 11, 2002 12:53 PM
Subject: [PATCH] Use static predefined ContentType
> Hello,
>
> I have prepared patch for using predefined const ContentType,
similar to
> patch was done to MimeType . I have traced MimeBodyPart.isMimeType
> implementation...
>
> Please find attached
>
> Best regards,
> Pavel
>
>
------------------------------------------------------------------------
--------
> --
> To unsubscribe, e-mail: <ma...@xml.apache.org>
> For additional commands, e-mail: <ma...@xml.apache.org>
--
To unsubscribe, e-mail: <ma...@xml.apache.org>
For additional commands, e-mail: <ma...@xml.apache.org>