[jira] Issue Comment Edited: (OODT-38) Remove License Test from Build Process

["Paul Ramirez (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OODT-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912561#action_12912561 ] 

Paul Ramirez edited comment on OODT-38 at 9/20/10 12:21 PM:
------------------------------------------------------------

I'm not sure we could pipe the excludes into a property that gets used at the core level as it may be convoluted as the sub modules have a set of excludes and I don't this there is a way to iterate over those excludes or includes in maven. 

What I think should be done is define the rat plugin at the core level in a profile and then if a sub module needs excludes override that definition in the sub module's pom. That way each time a new sub module is added they will have rat support by default but if they want excludes they will have to override the plugin to configure it. Seems like this is the best that can be done. If I don't hear any objections I will do that tomorrow. 

      was (Author: pramirez):
    I'm not sure we could pipe the excludes into a property that gets used at the core level as it may be convoluted as the sub modules have a set of excludes and I don't this there is a way to iterate over those excludes or includes in maven. 

What I think should be done is define the rat plugin at the core level in a profile and then if a sub module needs excludes override that definition in the sub module's pom. That way each time a new sub module is added they will have rat support by default but if they want excludes they will have to override the plugin to configure it. Seems like the best that can be done. If I don't hear any objections I will do that tomorrow. 
  
> Remove License Test from Build Process
> --------------------------------------
>
>                 Key: OODT-38
>                 URL: https://issues.apache.org/jira/browse/OODT-38
>             Project: OODT
>          Issue Type: Improvement
>          Components: build proces
>            Reporter: Paul Ramirez
>            Priority: Minor
>             Fix For: 0.1-incubating
>
>
> Currently during the build a failure is caused by a test that counts the number of unapproved licenses. While it is good to know that there are unapproved licenses it would seem like this should be something disconnected from the build process. Otherwise on a simple "mvn install" one runs into the following:
> [INFO] ------------------------------------------------------------------------
> [ERROR] BUILD FAILURE
> [INFO] ------------------------------------------------------------------------
> [INFO] Too many unapproved licenses: 133
> [INFO] ------------------------------------------------------------------------
> [INFO] For more information, run Maven with the -e switch
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 23 seconds
> [INFO] Finished at: Sun Sep 19 10:28:29 PDT 2010
> [INFO] Final Memory: 52M/123M
> [INFO] ------------------------------------------------------------------------

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.