You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2018/04/06 19:39:16 UTC
[GitHub] dewrich commented on a change in pull request #2081: Go support for /profileparameters
dewrich commented on a change in pull request #2081: Go support for /profileparameters
URL: https://github.com/apache/incubator-trafficcontrol/pull/2081#discussion_r179856838
##########
File path: traffic_ops/traffic_ops_golang/routes.go
##########
@@ -191,6 +192,12 @@ func Routes(d ServerData) ([]Route, http.Handler, error) {
{1.3, http.MethodPost, `profiles-wip/?$`, api.CreateHandler(profile.GetRefType(), d.DB), auth.PrivLevelOperations, Authenticated, nil},
{1.3, http.MethodDelete, `profiles-wip/{id}$`, api.DeleteHandler(profile.GetRefType(), d.DB), auth.PrivLevelOperations, Authenticated, nil},
+ //ProfileParameters
+ {1.3, http.MethodGet, `profileparameters/?(\.json)?$`, api.ReadHandler(profileparameter.GetRefType(), d.DB), auth.PrivLevelReadOnly, Authenticated, nil},
Review comment:
@mitchell852 Should it be at least `/profile_parameters`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services