You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by GitBox <gi...@apache.org> on 2022/09/30 08:34:10 UTC
[GitHub] [incubator-sedona] AkshayGogeri opened a new pull request, #695: [SEDONA-172] Add ST_LineFromMultiPoint Function to SEDONA SQL API
AkshayGogeri opened a new pull request, #695:
URL: https://github.com/apache/incubator-sedona/pull/695
## Did you read the Contributor Guide?
- Yes, I have read [Contributor Rules](https://sedona.apache.org/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/community/develop/)
## Is this PR related to a JIRA ticket?
- Yes, the URL of the assoicated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-172.
## What changes were proposed in this PR?
ST_LineFromMultiPoint Function
## How was this patch tested?
Scala, Python, Java integration tests
## Did this PR include necessary documentation updates?
- Yes, I have updated the documentation update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] jiayuasu merged pull request #695: [SEDONA-172] Add ST_LineFromMultiPoint Function to SEDONA SQL API
Posted by GitBox <gi...@apache.org>.
jiayuasu merged PR #695:
URL: https://github.com/apache/incubator-sedona/pull/695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-sedona] jiayuasu commented on a diff in pull request #695: [SEDONA-172] Add ST_LineFromMultiPoint Function to SEDONA SQL API
Posted by GitBox <gi...@apache.org>.
jiayuasu commented on code in PR #695:
URL: https://github.com/apache/incubator-sedona/pull/695#discussion_r985279161
##########
docs/api/sql/Function.md:
##########
@@ -1394,3 +1394,29 @@ SELECT ST_Z(ST_POINT(0.0 25.0 11.0))
```
Output: `11.0`
+
+## ST_LineFromMultiPoint
Review Comment:
Please put this function in an alphabetical order with other functions.
##########
docs/api/flink/Function.md:
##########
@@ -788,3 +788,22 @@ SELECT ST_Z(ST_POINT(0.0 25.0 11.0))
```
Output: `11.0`
+
+## ST_LineFromMultiPoint
Review Comment:
Please put this function in an alphabetical order with other functions.
##########
sql/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/Functions.scala:
##########
@@ -1287,3 +1287,16 @@ case class ST_Normalize(inputExpressions: Seq[Expression])
copy(inputExpressions = newChildren)
}
}
+
+/**
+ * Returns the LineString geometry given a MultiPoint geometry
+ *
+ * @param inputExpressions
Review Comment:
Please add a DataFrame style API in Python and Scala for this function. See PR #693 .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org