You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/05/12 09:18:24 UTC
[GitHub] [incubator-inlong] EMsnap opened a new pull request, #4176: [INLONG-4169][Sort] Add comments before classes in sort
EMsnap opened a new pull request, #4176:
URL: https://github.com/apache/incubator-inlong/pull/4176
### Title Name: [INLONG-4169][Sort] Add comments before classes in sort
Fixes #4169
### Motivation
currently there are many classes in sort that don't have enough comment
### Modifications
Add comments before classes in sort
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] yunqingmoswu commented on a diff in pull request #4176: [INLONG-4169][Sort] Add comments before classes in sort
Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on code in PR #4176:
URL: https://github.com/apache/incubator-inlong/pull/4176#discussion_r871158069
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/Node.java:
##########
@@ -33,6 +33,9 @@
import java.util.Map;
import java.util.TreeMap;
+/**
+ * Base class for extract node and load node
Review Comment:
It also contains transform node?
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/ExtractNode.java:
##########
@@ -35,6 +35,9 @@
import java.util.List;
import java.util.Map;
+/**
+ *
Review Comment:
This should be not empty?
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/load/HiveLoadNode.java:
##########
@@ -37,6 +37,9 @@
import java.util.List;
import java.util.Map;
+/**
+ * hive load node with FlinkCdc
Review Comment:
Does hive node belong to flink cdc? Is it more appropriate to belong to flink connector?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] healchow merged pull request #4176: [INLONG-4169][Sort] Add comments before classes in sort
Posted by GitBox <gi...@apache.org>.
healchow merged PR #4176:
URL: https://github.com/apache/incubator-inlong/pull/4176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] EMsnap commented on a diff in pull request #4176: [INLONG-4169][Sort] Add comments before classes in sort
Posted by GitBox <gi...@apache.org>.
EMsnap commented on code in PR #4176:
URL: https://github.com/apache/incubator-inlong/pull/4176#discussion_r871166716
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/load/HiveLoadNode.java:
##########
@@ -37,6 +37,9 @@
import java.util.List;
import java.util.Map;
+/**
+ * hive load node with FlinkCdc
Review Comment:
sure it's a typo, thanks
##########
inlong-sort/sort-common/src/main/java/org/apache/inlong/sort/protocol/node/Node.java:
##########
@@ -33,6 +33,9 @@
import java.util.Map;
import java.util.TreeMap;
+/**
+ * Base class for extract node and load node
Review Comment:
modified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org