You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmitro Lisnichenko <dl...@hortonworks.com> on 2014/03/31 16:36:09 UTC
Review Request 19847: supervisor.enable should be removed from Ambari's
Storm Config section
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19847/
-----------------------------------------------------------
Review request for Ambari and Vitalyi Brodetskyi.
Bugs: AMBARI-5282
https://issues.apache.org/jira/browse/AMBARI-5282
Repository: ambari
Description
-------
Ambari exposes the supervisor.enable property and in some early builds defaults it to true which causes the supervisor's to not launch workers assigned to them. The supervisor's will start up, the assignments are there, but the supervisor's just ignore them. We need to remove the supervisor.enable from Ambari as it seems like a very dangerous switch that doesn't have broad applicability.
Diffs
-----
ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/configuration/storm-site.xml 6eca8f9
ambari-web/app/assets/data/configurations/cluster_level_configs.json 1712a42
ambari-web/app/assets/data/wizard/stack/hdp/version2.0.1/STORM.json 5d1b134
ambari-web/app/data/HDP2/site_properties.js 0e778bb
Diff: https://reviews.apache.org/r/19847/diff/
Testing
-------
----------------------------------------------------------------------
Ran 190 tests in 0.404s
OK
----------------------------------------------------------------------
Total run:510
Total errors:0
Total failures:0
OK
ambari-web-test:
[INFO] Executed tasks
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 6.650s
[INFO] Finished at: Mon Mar 31 17:34:52 FET 2014
[INFO] Final Memory: 6M/110M
[INFO] ------------------------------------------------------------------------
Thanks,
Dmitro Lisnichenko
Re: Review Request 19847: supervisor.enable should be removed from Ambari's
Storm Config section
Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19847/#review39039
-----------------------------------------------------------
Ship it!
Ship It!
- Vitalyi Brodetskyi
On March 31, 2014, 2:36 p.m., Dmitro Lisnichenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19847/
> -----------------------------------------------------------
>
> (Updated March 31, 2014, 2:36 p.m.)
>
>
> Review request for Ambari and Vitalyi Brodetskyi.
>
>
> Bugs: AMBARI-5282
> https://issues.apache.org/jira/browse/AMBARI-5282
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Ambari exposes the supervisor.enable property and in some early builds defaults it to true which causes the supervisor's to not launch workers assigned to them. The supervisor's will start up, the assignments are there, but the supervisor's just ignore them. We need to remove the supervisor.enable from Ambari as it seems like a very dangerous switch that doesn't have broad applicability.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/stacks/HDP/2.1/services/STORM/configuration/storm-site.xml 6eca8f9
> ambari-web/app/assets/data/configurations/cluster_level_configs.json 1712a42
> ambari-web/app/assets/data/wizard/stack/hdp/version2.0.1/STORM.json 5d1b134
> ambari-web/app/data/HDP2/site_properties.js 0e778bb
>
> Diff: https://reviews.apache.org/r/19847/diff/
>
>
> Testing
> -------
>
>
> ----------------------------------------------------------------------
> Ran 190 tests in 0.404s
>
> OK
> ----------------------------------------------------------------------
> Total run:510
> Total errors:0
> Total failures:0
> OK
>
> ambari-web-test:
> [INFO] Executed tasks
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 6.650s
> [INFO] Finished at: Mon Mar 31 17:34:52 FET 2014
> [INFO] Final Memory: 6M/110M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Dmitro Lisnichenko
>
>