You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@beehive.apache.org by "Scott Symmank (JIRA)" <be...@incubator.apache.org> on 2005/02/11 22:30:12 UTC

[jira] Created: (BEEHIVE-288) Compiler: A jpf which has a 2 forward annotations with the same name on the same action is NOT producing a warning or error

Compiler: A jpf which has a 2 forward annotations  with the same name on the same action is NOT producing a warning or error
----------------------------------------------------------------------------------------------------------------------------

         Key: BEEHIVE-288
         URL: http://issues.apache.org/jira/browse/BEEHIVE-288
     Project: Beehive
        Type: Bug
  Components: NetUI  
    Versions: V1Beta    
    Reporter: Scott Symmank
 Assigned to: Rich Feit 
    Priority: Minor


The compiler should print a warning or error, if an action has duplicate
forwards. 

see page1() below:


<snip>
package Test3;

import org.apache.beehive.netui.pageflow.*;
import org.apache.beehive.netui.pageflow.annotations.Jpf;

/**
 *******************************************************************************
 *
 * @desc: This PageFlowController file contains an ActionForward method named "page1"
 * that declares two forwards of the same name.
 *
 * @result: The compiler should catch this and report an error or at least a warning.
 *
 ******************************************************************************/
@Jpf.Controller()
public class Controller extends PageFlowController
    {
    @Jpf.Action(
        forwards = {
            @Jpf.Forward(
                name = "pg1",
                path = "Pg1.jsp") 
        })
    protected Forward begin()
        {
        return new Forward("pg1");
        }

    @Jpf.Action(
        forwards = {
            @Jpf.Forward(
                name = "pg1",
                path = "Pg1.jsp"),
            @Jpf.Forward(
                name = "pg1",
                path = "Pg1.jsp") 
        })
    protected Forward page1()
        {
        return new Forward("pg1");
        }
    }
</snip>


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Resolved: (BEEHIVE-288) Compiler: A jpf which has 2 forward annotations with the same name on the same action, is NOT producing a warning or error

Posted by "Rich Feit (JIRA)" <be...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-288?page=history ]
     
Rich Feit resolved BEEHIVE-288:
-------------------------------

     Resolution: Fixed
    Fix Version: V1Beta

Fixed with revision 154639.  This was actually due to a bug in Sun's Mirror implementation (the same annotation retrieved in different ways does not equal itself), but I found a workaround.

> Compiler: A jpf which has 2 forward annotations  with the same name on the same action, is NOT producing a warning or error
> ---------------------------------------------------------------------------------------------------------------------------
>
>          Key: BEEHIVE-288
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-288
>      Project: Beehive
>         Type: Bug
>   Components: NetUI
>     Versions: V1Beta
>     Reporter: Scott Symmank
>     Assignee: Rich Feit
>     Priority: Minor
>      Fix For: V1Beta

>
> The compiler should print a warning or error, if an action has duplicate
> forwards. 
> see page1() below:
> <snip>
> package Test3;
> import org.apache.beehive.netui.pageflow.*;
> import org.apache.beehive.netui.pageflow.annotations.Jpf;
> /**
>  *******************************************************************************
>  *
>  * @desc: This PageFlowController file contains an ActionForward method named "page1"
>  * that declares two forwards of the same name.
>  *
>  * @result: The compiler should catch this and report an error or at least a warning.
>  *
>  ******************************************************************************/
> @Jpf.Controller()
> public class Controller extends PageFlowController
>     {
>     @Jpf.Action(
>         forwards = {
>             @Jpf.Forward(
>                 name = "pg1",
>                 path = "Pg1.jsp") 
>         })
>     protected Forward begin()
>         {
>         return new Forward("pg1");
>         }
>     @Jpf.Action(
>         forwards = {
>             @Jpf.Forward(
>                 name = "pg1",
>                 path = "Pg1.jsp"),
>             @Jpf.Forward(
>                 name = "pg1",
>                 path = "Pg1.jsp") 
>         })
>     protected Forward page1()
>         {
>         return new Forward("pg1");
>         }
>     }
> </snip>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Closed: (BEEHIVE-288) Compiler: A jpf which has 2 forward annotations with the same name on the same action, is NOT producing a warning or error

Posted by "Julie Zhuo (JIRA)" <be...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-288?page=all ]
     
Julie Zhuo closed BEEHIVE-288:
------------------------------


Verified at rev171061. It now generates compiler error for both cases.

> Compiler: A jpf which has 2 forward annotations  with the same name on the same action, is NOT producing a warning or error
> ---------------------------------------------------------------------------------------------------------------------------
>
>          Key: BEEHIVE-288
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-288
>      Project: Beehive
>         Type: Bug
>   Components: NetUI
>     Versions: V1Beta
>     Reporter: Scott Symmank
>     Assignee: Julie Zhuo
>     Priority: Minor
>      Fix For: V1Beta

>
> The compiler should print a warning or error, if an action has duplicate
> forwards. 
> see page1() below:
> <snip>
> package Test3;
> import org.apache.beehive.netui.pageflow.*;
> import org.apache.beehive.netui.pageflow.annotations.Jpf;
> /**
>  *******************************************************************************
>  *
>  * @desc: This PageFlowController file contains an ActionForward method named "page1"
>  * that declares two forwards of the same name.
>  *
>  * @result: The compiler should catch this and report an error or at least a warning.
>  *
>  ******************************************************************************/
> @Jpf.Controller()
> public class Controller extends PageFlowController
>     {
>     @Jpf.Action(
>         forwards = {
>             @Jpf.Forward(
>                 name = "pg1",
>                 path = "Pg1.jsp") 
>         })
>     protected Forward begin()
>         {
>         return new Forward("pg1");
>         }
>     @Jpf.Action(
>         forwards = {
>             @Jpf.Forward(
>                 name = "pg1",
>                 path = "Pg1.jsp"),
>             @Jpf.Forward(
>                 name = "pg1",
>                 path = "Pg1.jsp") 
>         })
>     protected Forward page1()
>         {
>         return new Forward("pg1");
>         }
>     }
> </snip>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (BEEHIVE-288) Compiler: A jpf which has 2 forward annotations with the same name on the same action, is NOT producing a warning or error

Posted by "Rich Feit (JIRA)" <be...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-288?page=history ]

Rich Feit reassigned BEEHIVE-288:
---------------------------------

    Assign To: Alejandro Ramirez  (was: Rich Feit)

> Compiler: A jpf which has 2 forward annotations  with the same name on the same action, is NOT producing a warning or error
> ---------------------------------------------------------------------------------------------------------------------------
>
>          Key: BEEHIVE-288
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-288
>      Project: Beehive
>         Type: Bug
>   Components: NetUI
>     Versions: V1Beta
>     Reporter: Scott Symmank
>     Assignee: Alejandro Ramirez
>     Priority: Minor
>      Fix For: V1Beta

>
> The compiler should print a warning or error, if an action has duplicate
> forwards. 
> see page1() below:
> <snip>
> package Test3;
> import org.apache.beehive.netui.pageflow.*;
> import org.apache.beehive.netui.pageflow.annotations.Jpf;
> /**
>  *******************************************************************************
>  *
>  * @desc: This PageFlowController file contains an ActionForward method named "page1"
>  * that declares two forwards of the same name.
>  *
>  * @result: The compiler should catch this and report an error or at least a warning.
>  *
>  ******************************************************************************/
> @Jpf.Controller()
> public class Controller extends PageFlowController
>     {
>     @Jpf.Action(
>         forwards = {
>             @Jpf.Forward(
>                 name = "pg1",
>                 path = "Pg1.jsp") 
>         })
>     protected Forward begin()
>         {
>         return new Forward("pg1");
>         }
>     @Jpf.Action(
>         forwards = {
>             @Jpf.Forward(
>                 name = "pg1",
>                 path = "Pg1.jsp"),
>             @Jpf.Forward(
>                 name = "pg1",
>                 path = "Pg1.jsp") 
>         })
>     protected Forward page1()
>         {
>         return new Forward("pg1");
>         }
>     }
> </snip>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Commented: (BEEHIVE-288) Compiler: A jpf which has 2 forward annotations with the same name on the same action, is NOT producing a warning or error

Posted by "Jeremiah Johnson (JIRA)" <be...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-288?page=comments#action_59050 ]
     
Jeremiah Johnson commented on BEEHIVE-288:
------------------------------------------

In case this is helpful while trying to resolve the issue, here are some things that I have noticed: if the name and the path are the same, then the duplicate is ignored; if the paths differ then you get errors.

---
    @Jpf.Action(
        forwards = {
            @Jpf.Forward(
                name = "pg1",
                path = "Pg1.jsp"),
            @Jpf.Forward(
                name = "pg1",
                path = "Pg1.jsp")
        })
    protected Forward page1()
        {
        return new Forward("pg1");
        }
--- compiles fine

--- 
    @Jpf.Action(
        forwards = {
            @Jpf.Forward(
                name = "pg1",
                path = "Pg1.jsp"),
            @Jpf.Forward(
                name = "pg1",
                path = "Pg2.jsp")
        })
    protected Forward page1()
        {
        return new Forward("pg1");
        }
--- results in ...
      [apt] Compiling 11 source files to /home/jjohnson/projects/.../webapp/WEB-INF/classes
      [apt] /home/jjohnson/projects/.../webapp/WEB-INF/src/admin/Controller.java:102: Duplicate Forward tag with name="pg1".
      [apt]     protected Forward page1()
      [apt]                       ^
      [apt] /home/jjohnson/projects/.../webapp/WEB-INF/src/admin/Controller.java:102: Duplicate Forward tag with name="pg1".
      [apt]     protected Forward page1()
      [apt]                       ^
      [apt] 2 errors
---

- jeremiah

> Compiler: A jpf which has 2 forward annotations  with the same name on the same action, is NOT producing a warning or error
> ---------------------------------------------------------------------------------------------------------------------------
>
>          Key: BEEHIVE-288
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-288
>      Project: Beehive
>         Type: Bug
>   Components: NetUI
>     Versions: V1Beta
>     Reporter: Scott Symmank
>     Assignee: Rich Feit
>     Priority: Minor

>
> The compiler should print a warning or error, if an action has duplicate
> forwards. 
> see page1() below:
> <snip>
> package Test3;
> import org.apache.beehive.netui.pageflow.*;
> import org.apache.beehive.netui.pageflow.annotations.Jpf;
> /**
>  *******************************************************************************
>  *
>  * @desc: This PageFlowController file contains an ActionForward method named "page1"
>  * that declares two forwards of the same name.
>  *
>  * @result: The compiler should catch this and report an error or at least a warning.
>  *
>  ******************************************************************************/
> @Jpf.Controller()
> public class Controller extends PageFlowController
>     {
>     @Jpf.Action(
>         forwards = {
>             @Jpf.Forward(
>                 name = "pg1",
>                 path = "Pg1.jsp") 
>         })
>     protected Forward begin()
>         {
>         return new Forward("pg1");
>         }
>     @Jpf.Action(
>         forwards = {
>             @Jpf.Forward(
>                 name = "pg1",
>                 path = "Pg1.jsp"),
>             @Jpf.Forward(
>                 name = "pg1",
>                 path = "Pg1.jsp") 
>         })
>     protected Forward page1()
>         {
>         return new Forward("pg1");
>         }
>     }
> </snip>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (BEEHIVE-288) Compiler: A jpf which has 2 forward annotations with the same name on the same action, is NOT producing a warning or error

Posted by "Alejandro Ramirez (JIRA)" <be...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-288?page=history ]

Alejandro Ramirez reassigned BEEHIVE-288:
-----------------------------------------

    Assign To: Scott Symmank  (was: Alejandro Ramirez)

Please verify.

> Compiler: A jpf which has 2 forward annotations  with the same name on the same action, is NOT producing a warning or error
> ---------------------------------------------------------------------------------------------------------------------------
>
>          Key: BEEHIVE-288
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-288
>      Project: Beehive
>         Type: Bug
>   Components: NetUI
>     Versions: V1Beta
>     Reporter: Scott Symmank
>     Assignee: Scott Symmank
>     Priority: Minor
>      Fix For: V1Beta

>
> The compiler should print a warning or error, if an action has duplicate
> forwards. 
> see page1() below:
> <snip>
> package Test3;
> import org.apache.beehive.netui.pageflow.*;
> import org.apache.beehive.netui.pageflow.annotations.Jpf;
> /**
>  *******************************************************************************
>  *
>  * @desc: This PageFlowController file contains an ActionForward method named "page1"
>  * that declares two forwards of the same name.
>  *
>  * @result: The compiler should catch this and report an error or at least a warning.
>  *
>  ******************************************************************************/
> @Jpf.Controller()
> public class Controller extends PageFlowController
>     {
>     @Jpf.Action(
>         forwards = {
>             @Jpf.Forward(
>                 name = "pg1",
>                 path = "Pg1.jsp") 
>         })
>     protected Forward begin()
>         {
>         return new Forward("pg1");
>         }
>     @Jpf.Action(
>         forwards = {
>             @Jpf.Forward(
>                 name = "pg1",
>                 path = "Pg1.jsp"),
>             @Jpf.Forward(
>                 name = "pg1",
>                 path = "Pg1.jsp") 
>         })
>     protected Forward page1()
>         {
>         return new Forward("pg1");
>         }
>     }
> </snip>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


[jira] Assigned: (BEEHIVE-288) Compiler: A jpf which has 2 forward annotations with the same name on the same action, is NOT producing a warning or error

Posted by "Alejandro Ramirez (JIRA)" <be...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-288?page=all ]

Alejandro Ramirez reassigned BEEHIVE-288:
-----------------------------------------

    Assign To: Julie Zhuo  (was: Scott Symmank)

Please verify.

> Compiler: A jpf which has 2 forward annotations  with the same name on the same action, is NOT producing a warning or error
> ---------------------------------------------------------------------------------------------------------------------------
>
>          Key: BEEHIVE-288
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-288
>      Project: Beehive
>         Type: Bug
>   Components: NetUI
>     Versions: V1Beta
>     Reporter: Scott Symmank
>     Assignee: Julie Zhuo
>     Priority: Minor
>      Fix For: V1Beta

>
> The compiler should print a warning or error, if an action has duplicate
> forwards. 
> see page1() below:
> <snip>
> package Test3;
> import org.apache.beehive.netui.pageflow.*;
> import org.apache.beehive.netui.pageflow.annotations.Jpf;
> /**
>  *******************************************************************************
>  *
>  * @desc: This PageFlowController file contains an ActionForward method named "page1"
>  * that declares two forwards of the same name.
>  *
>  * @result: The compiler should catch this and report an error or at least a warning.
>  *
>  ******************************************************************************/
> @Jpf.Controller()
> public class Controller extends PageFlowController
>     {
>     @Jpf.Action(
>         forwards = {
>             @Jpf.Forward(
>                 name = "pg1",
>                 path = "Pg1.jsp") 
>         })
>     protected Forward begin()
>         {
>         return new Forward("pg1");
>         }
>     @Jpf.Action(
>         forwards = {
>             @Jpf.Forward(
>                 name = "pg1",
>                 path = "Pg1.jsp"),
>             @Jpf.Forward(
>                 name = "pg1",
>                 path = "Pg1.jsp") 
>         })
>     protected Forward page1()
>         {
>         return new Forward("pg1");
>         }
>     }
> </snip>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


[jira] Updated: (BEEHIVE-288) Compiler: A jpf which has 2 forward annotations with the same name on the same action, is NOT producing a warning or error

Posted by "Scott Symmank (JIRA)" <be...@incubator.apache.org>.
     [ http://issues.apache.org/jira/browse/BEEHIVE-288?page=history ]

Scott Symmank updated BEEHIVE-288:
----------------------------------

    Summary: Compiler: A jpf which has 2 forward annotations  with the same name on the same action, is NOT producing a warning or error  (was: Compiler: A jpf which has a 2 forward annotations  with the same name on the same action is NOT producing a warning or error)

> Compiler: A jpf which has 2 forward annotations  with the same name on the same action, is NOT producing a warning or error
> ---------------------------------------------------------------------------------------------------------------------------
>
>          Key: BEEHIVE-288
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-288
>      Project: Beehive
>         Type: Bug
>   Components: NetUI
>     Versions: V1Beta
>     Reporter: Scott Symmank
>     Assignee: Rich Feit
>     Priority: Minor

>
> The compiler should print a warning or error, if an action has duplicate
> forwards. 
> see page1() below:
> <snip>
> package Test3;
> import org.apache.beehive.netui.pageflow.*;
> import org.apache.beehive.netui.pageflow.annotations.Jpf;
> /**
>  *******************************************************************************
>  *
>  * @desc: This PageFlowController file contains an ActionForward method named "page1"
>  * that declares two forwards of the same name.
>  *
>  * @result: The compiler should catch this and report an error or at least a warning.
>  *
>  ******************************************************************************/
> @Jpf.Controller()
> public class Controller extends PageFlowController
>     {
>     @Jpf.Action(
>         forwards = {
>             @Jpf.Forward(
>                 name = "pg1",
>                 path = "Pg1.jsp") 
>         })
>     protected Forward begin()
>         {
>         return new Forward("pg1");
>         }
>     @Jpf.Action(
>         forwards = {
>             @Jpf.Forward(
>                 name = "pg1",
>                 path = "Pg1.jsp"),
>             @Jpf.Forward(
>                 name = "pg1",
>                 path = "Pg1.jsp") 
>         })
>     protected Forward page1()
>         {
>         return new Forward("pg1");
>         }
>     }
> </snip>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira