You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Gautam Borad <gb...@gmail.com> on 2015/02/23 10:32:34 UTC

Review Request 31298: Spark UI: Add descriptions to Spark Default configuration and fix label in Quick links

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31298/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Giridharan Kesavan, and Yusaku Sako.


Bugs: AMBARI-9744
    https://issues.apache.org/jira/browse/AMBARI-9744


Repository: ambari


Description
-------

Following minor changes are required:
1] Add description to fields of spark default
2] Change label of Quick link to match with component name.


Diffs
-----

  ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/configuration/spark-defaults.xml 20989b3 
  ambari-web/app/models/quick_links.js 686d919 

Diff: https://reviews.apache.org/r/31298/diff/


Testing
-------

Tested on 3 node CentOS 6 cluster:
1] The descriptions were present
2] The quick link label was changed


Thanks,

Gautam Borad


Re: Review Request 31298: Spark UI: Add descriptions to Spark Default configuration and fix label in Quick links

Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31298/#review73742
-----------------------------------------------------------

Ship it!


Ship It!

- Yusaku Sako


On Feb. 23, 2015, 9:32 a.m., Gautam Borad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31298/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2015, 9:32 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Giridharan Kesavan, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-9744
>     https://issues.apache.org/jira/browse/AMBARI-9744
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Following minor changes are required:
> 1] Add description to fields of spark default
> 2] Change label of Quick link to match with component name.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/SPARK/1.2.0.2.2/configuration/spark-defaults.xml 20989b3 
>   ambari-web/app/models/quick_links.js 686d919 
> 
> Diff: https://reviews.apache.org/r/31298/diff/
> 
> 
> Testing
> -------
> 
> Tested on 3 node CentOS 6 cluster:
> 1] The descriptions were present
> 2] The quick link label was changed
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>