[GitHub] [superset] pkdotson commented on a change in pull request #15560: refactor: icon to icons for headeractionsdropdown

[GitBox <gi...@apache.org>]

pkdotson commented on a change in pull request #15560:
URL: https://github.com/apache/superset/pull/15560#discussion_r665566582



##########
File path: superset-frontend/src/dashboard/components/Header/HeaderActionsDropdown/index.jsx
##########
@@ -88,6 +88,9 @@ const MENU_KEYS = {
 
 const DropdownButton = styled.div`
   margin-left: ${({ theme }) => theme.gridUnit * 2.5}px;
+  span {
+    color: ${({ theme }) => theme.colors.grayscale.base};

Review comment:
       We pretty much decided to let it inherit the color from the parent since most case present that way.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org